[PATCH net v2] openvswitch: disable LRO

[PATCH net v2] openvswitch: disable LRO

[Jiri Benc]

Currently, openvswitch tries to disable LRO from the user space. This does
not work correctly when the device added is a vlan interface, though.
Instead of dealing with possibly complex stacked cross name space relations
in the user space, do the same as bridging does and call dev_disable_lro in
the kernel.

Signed-off-by: Jiri Benc <jbenc@redhat.com>
---
v1->v2: Disable LRO unconditionally. If the feature that leaves LRO enabled
is implemented in the future in ovs user space, the conditional disablement
can be implemented in the kernel easily. There won't be any problem even
if such new ovs user space is run with older kernels, enabling LRO is just
an optimization.
---
 net/openvswitch/vport-netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 4776282c6417..33e6d6e2908f 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -125,6 +125,7 @@ static struct vport *netdev_create(const struct vport_parms *parms)
 	if (err)
 		goto error_master_upper_dev_unlink;
 
+	dev_disable_lro(netdev_vport->dev);
 	dev_set_promiscuity(netdev_vport->dev, 1);
 	netdev_vport->dev->priv_flags |= IFF_OVS_DATAPATH;
 	rtnl_unlock();
-- 
1.8.3.1

Re: [PATCH net v2] openvswitch: disable LRO

[Flavio Leitner]

On Thu, May 28, 2015 at 03:04:53PM +0200, Jiri Benc wrote:
> Currently, openvswitch tries to disable LRO from the user space. This does
> not work correctly when the device added is a vlan interface, though.
> Instead of dealing with possibly complex stacked cross name space relations
> in the user space, do the same as bridging does and call dev_disable_lro in
> the kernel.
> 
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
> ---
LGTM
Acked-by: Flavio Leitner <fbl@redhat.com>

Re: [PATCH net v2] openvswitch: disable LRO

[Pravin Shelar]

On Thu, May 28, 2015 at 6:04 AM, Jiri Benc <jbenc@redhat.com> wrote:
> Currently, openvswitch tries to disable LRO from the user space. This does
> not work correctly when the device added is a vlan interface, though.
> Instead of dealing with possibly complex stacked cross name space relations
> in the user space, do the same as bridging does and call dev_disable_lro in
> the kernel.
>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>

Looks good.
Acked-by: Pravin B Shelar <pshelar@nicira.com>