From: Pavan Chebbi <pavan.chebbi@broadcom.com>
To: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jon Ringle <jringle@gridpoint.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH 1/2] net: encx24j600: Add parentheses to fix precedence
Date: Fri, 2 Dec 2022 13:20:36 +0530 [thread overview]
Message-ID: <CALs4sv3_YEnE4SGoUJZQBSA+ymFUJ=Njv0P2mi1QgfDD2ewOOA@mail.gmail.com> (raw)
In-Reply-To: <20221201173408.26954-1-goncharenko.vp@ispras.ru>
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
On Thu, Dec 1, 2022 at 11:04 PM Valentina Goncharenko
<goncharenko.vp@ispras.ru> wrote:
>
> In functions regmap_encx24j600_phy_reg_read() and
> regmap_encx24j600_phy_reg_write() in the conditions of the waiting
> cycles for filling the variable 'ret' it is necessary to add parentheses
> to prevent wrong assignment due to logical operations precedence.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d70e53262f5c ("net: Microchip encx24j600 driver")
> Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
> ---
> drivers/net/ethernet/microchip/encx24j600-regmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c
> index 81a8ccca7e5e..2e337c7a5773 100644
> --- a/drivers/net/ethernet/microchip/encx24j600-regmap.c
> +++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c
> @@ -359,7 +359,7 @@ static int regmap_encx24j600_phy_reg_read(void *context, unsigned int reg,
> goto err_out;
>
> usleep_range(26, 100);
> - while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) &&
> + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) &&
> (mistat & BUSY))
> cpu_relax();
>
> @@ -397,7 +397,7 @@ static int regmap_encx24j600_phy_reg_write(void *context, unsigned int reg,
> goto err_out;
>
> usleep_range(26, 100);
> - while ((ret = regmap_read(ctx->regmap, MISTAT, &mistat) != 0) &&
> + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) &&
> (mistat & BUSY))
> cpu_relax();
>
> --
> 2.25.1
>
Makes sense to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2022-12-02 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 17:34 [PATCH 1/2] net: encx24j600: Add parentheses to fix precedence Valentina Goncharenko
2022-12-01 17:34 ` [PATCH 2/2] net: encx24j600: Fix invalid logic in reading of MISTAT register Valentina Goncharenko
2022-12-02 7:55 ` Pavan Chebbi
2022-12-02 7:50 ` Pavan Chebbi [this message]
2022-12-05 9:50 ` [PATCH 1/2] net: encx24j600: Add parentheses to fix precedence patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALs4sv3_YEnE4SGoUJZQBSA+ymFUJ=Njv0P2mi1QgfDD2ewOOA@mail.gmail.com' \
--to=pavan.chebbi@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=goncharenko.vp@ispras.ru \
--cc=jringle@gridpoint.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).