From: Tom Herbert <tom@herbertland.com>
To: David Miller <davem@davemloft.net>
Cc: Jarno Rajahalme <jarno@ovn.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH net v3 2/2] udp_offload: Set encapsulation before inner completes.
Date: Fri, 6 May 2016 13:20:57 -0700 [thread overview]
Message-ID: <CALx6S34AZ6t5t5VqodMFB4PVVYf4w+4SA+a6frsySOiJ9qVCRA@mail.gmail.com> (raw)
In-Reply-To: <20160506.153412.1756777490005831525.davem@davemloft.net>
On Fri, May 6, 2016 at 12:34 PM, David Miller <davem@davemloft.net> wrote:
> From: Jarno Rajahalme <jarno@ovn.org>
> Date: Tue, 3 May 2016 16:10:21 -0700
>
>> UDP tunnel segmentation code relies on the inner offsets being set for
>> an UDP tunnel GSO packet, but the inner *_complete() functions will
>> set the inner offsets only if 'encapsulation' is set before calling
>> them. Currently, udp_gro_complete() sets 'encapsulation' only after
>> the inner *_complete() functions are done. This causes the inner
>> offsets having invalid values after udp_gro_complete() returns, which
>> in turn will make it impossible to properly segment the packet in case
>> it needs to be forwarded, which would be visible to the user either as
>> invalid packets being sent or as packet loss.
>>
>> This patch fixes this by setting skb's 'encapsulation' in
>> udp_gro_complete() before calling into the inner complete functions,
>> and by making each possible UDP tunnel gro_complete() callback set the
>> inner_mac_header to the beginning of the tunnel payload.
>>
>> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
>> ---
>> v3: Added setting inner_mac_header from all possible callbacks to cover
>> cases where there is no inner mac header.
>
> Alex and Tom, can you please review this new version since you guys had
> so much feedback for v2?
>
I'm okay with the patch.Clarifying exactly what skb->encaspulation
means is future work.
> THanks.
next prev parent reply other threads:[~2016-05-06 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 23:10 [PATCH net v3 1/2] udp_tunnel: Remove redundant udp_tunnel_gro_complete() Jarno Rajahalme
2016-05-03 23:10 ` [PATCH net v3 2/2] udp_offload: Set encapsulation before inner completes Jarno Rajahalme
2016-05-06 19:34 ` David Miller
2016-05-06 19:52 ` Alexander Duyck
2016-05-06 20:20 ` Tom Herbert [this message]
2016-05-06 22:25 ` David Miller
2016-05-06 22:25 ` [PATCH net v3 1/2] udp_tunnel: Remove redundant udp_tunnel_gro_complete() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALx6S34AZ6t5t5VqodMFB4PVVYf4w+4SA+a6frsySOiJ9qVCRA@mail.gmail.com \
--to=tom@herbertland.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).