From: Tom Herbert <tom@herbertland.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/3] support changing steering policies in tuntap
Date: Wed, 27 Sep 2017 22:02:31 -0700 [thread overview]
Message-ID: <CALx6S352oFfvhiOP8YAX2RHV=8SAYDh=iASWzCuiy6COLB2bYQ@mail.gmail.com> (raw)
In-Reply-To: <CAF=yD-J8hERZdwq8FJ2rtnCnZ2b7s=CAVLtPk4CS7e=RQH3sLQ@mail.gmail.com>
On Wed, Sep 27, 2017 at 4:25 PM, Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>>> In the future, both simple and sophisticated policy like RSS or other guest
>>> driven steering policies could be done on top.
>>
>> IMHO there should be a more practical example before adding all this
>> indirection. And it would be nice to understand why this queue selection
>> needs to be tun specific.
>
> I was thinking the same and this reminds me of the various strategies
> implemented in packet fanout. tun_cpu_select_queue is analogous to
> fanout_demux_cpu though it is tun-specific in that it requires tun->numqueues.
>
> Fanout accrued various strategies until it gained an eBPF variant. Just
> supporting BPF is probably sufficient here, too.
+1, in addition to packet fanout, we have SO_REUSEPORT with BPF, RPS,
RFS, etc. It would be nice if existing packet steering mechanisms
could be leveraged for tun.
next prev parent reply other threads:[~2017-09-28 5:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 8:23 [PATCH net-next 0/3] support changing steering policies in tuntap Jason Wang
2017-09-27 8:23 ` [PATCH net-next 1/3] tun: abstract flow steering logic Jason Wang
2017-09-27 8:23 ` [PATCH net-next 2/3] tun: introduce ioctls to set and get steering policies Jason Wang
2017-09-27 8:23 ` [PATCH net-next 3/3] tun: introduce cpu id based steering policy Jason Wang
2017-09-27 22:13 ` [PATCH net-next 0/3] support changing steering policies in tuntap Michael S. Tsirkin
2017-09-27 23:25 ` Willem de Bruijn
2017-09-28 5:02 ` Tom Herbert [this message]
2017-09-28 7:53 ` Jason Wang
2017-09-28 7:23 ` Jason Wang
2017-09-28 16:09 ` Willem de Bruijn
2017-09-29 9:41 ` Jason Wang
2017-10-01 3:28 ` Michael S. Tsirkin
2017-09-28 6:50 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALx6S352oFfvhiOP8YAX2RHV=8SAYDh=iASWzCuiy6COLB2bYQ@mail.gmail.com' \
--to=tom@herbertland.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).