From: Tom Herbert <tom@herbertland.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jerry Chu <hkchu@google.com>
Subject: Re: TCP fast open using experimental TCP option?
Date: Tue, 25 Apr 2017 17:39:31 -0700 [thread overview]
Message-ID: <CALx6S35e2_92sYUR88YO10m_OhseeTjTr-nGWvpairOAY0_APQ@mail.gmail.com> (raw)
In-Reply-To: <1493165636.6453.56.camel@edumazet-glaptop3.roam.corp.google.com>
On Tue, Apr 25, 2017 at 5:13 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Tue, 2017-04-25 at 12:08 -0700, Tom Herbert wrote:
>> Looks like TCP fast open was using experimental TCP option at some. Is
>> this still needed? Technically this violates usage requirements of
>> experimental options. Can this be removed now since there is now an
>> assigned option number for TFO?
>>
>> case TCPOPT_EXP:
>> /* Fast Open option shares code 254 using a
>> * 16 bits magic number.
>> */
>> if (opsize >= TCPOLEN_EXP_FASTOPEN_BASE &&
>> get_unaligned_be16(ptr) ==
>> TCPOPT_FASTOPEN_MAGIC)
>> tcp_parse_fastopen_option(opsize -
>> TCPOLEN_EXP_FASTOPEN_BASE,
>> ptr + 2, th->syn, foc, true);
>> break;
>
> Hi Tom
>
> Client side was updated in linux-4.1 only two years ago.
>
> We lack counters telling how often the experimental option is used.
>
> RFC6994 ( 5. Migration to Assigned Options ) guidelines are properly
> met.
>
> Not sure why we should hurry ?
>
An IETFer was complaining that Linux indiscriminately violates TCP
RFCs and gave the use of experimental options as example. Yuchung
pointed out that this use is actually conformant to the spec so we're
good (thanks Yuchung!).
Tom
>
prev parent reply other threads:[~2017-04-26 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 19:08 TCP fast open using experimental TCP option? Tom Herbert
2017-04-25 21:00 ` Yuchung Cheng
2017-04-26 0:13 ` Eric Dumazet
2017-04-26 0:39 ` Tom Herbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALx6S35e2_92sYUR88YO10m_OhseeTjTr-nGWvpairOAY0_APQ@mail.gmail.com \
--to=tom@herbertland.com \
--cc=eric.dumazet@gmail.com \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).