Re: [PATCH net-next 01/11] net/mlx5_core: Set irq affinity hints

[Saeed Mahameed <saeedm@dev.mellanox.co.il>]

On Fri, Apr 10, 2015 at 11:27 AM, Ido Shamay <idos@dev.mellanox.co.il> wrote:
> On 4/8/2015 5:51 PM, Amir Vadai wrote:
>>
>> From: Saeed Mahameed <saeedm@mellanox.com>
>>
>> +       int numa_node           =
>> +#if IS_ENABLED(CONFIG_NUMA)
>> +               mdev->pdev->dev.numa_node;
>> +#else
>> +               -1;
>> +#endif
>
> Would be nicer to use dev_to_node helper here, which already checks for
> CONFIG_NUMA
>
> include/linux/device.h:
> #ifdef CONFIG_NUMA
> static inline int dev_to_node(struct device *dev)
> {
>         return dev->numa_node;
> }
> static inline void set_dev_node(struct device *dev, int node)
> {
>         dev->numa_node = node;
> }
> #else
> static inline int dev_to_node(struct device *dev)
> {
>         return -1;
> }
> static inline void set_dev_node(struct device *dev, int node)
> {
> }
> #endif
Right, will fix in V1