From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
To: Joe Perches <joe@perches.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [net-next 10/15] net/mlx5: Add a blank line after declarations
Date: Thu, 24 Aug 2017 15:58:57 +0300 [thread overview]
Message-ID: <CALzJLG9GOgzOOOM+shw4ECxp6XcteePyBmo6V47_sF=YDYEidA@mail.gmail.com> (raw)
In-Reply-To: <1503527941.27867.2.camel@perches.com>
On Thu, Aug 24, 2017 at 1:39 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-08-17 at 16:29 +0300, Saeed Mahameed wrote:
>> From: Or Gerlitz <ogerlitz@mellanox.com>
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
> []
>> @@ -188,6 +188,7 @@ static enum mlx5_dev_event port_subtype_event(u8 subtype)
>> static void eq_update_ci(struct mlx5_eq *eq, int arm)
>> {
>> __be32 __iomem *addr = eq->doorbell + (arm ? 0 : 2);
>> +
>> u32 val = (eq->cons_index & 0xffffff) | (eq->eqn << 24);
>> __raw_writel((__force u32)cpu_to_be32(val), addr);
>> /* We still want ordering, just not swabbing, so add a barrier */
>
> checkpatch is stupid.
>
> The blank line should be after u32 val = ...
> and not after __be32 __iomem *addr = ...
>
>
You are completely right ! will fix this, Thanks !
next prev parent reply other threads:[~2017-08-24 12:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 13:29 [pull request][net-next 00/15] Mellanox, mlx5 updates 2017-08-17 Saeed Mahameed
2017-08-17 13:29 ` [net-next 01/15] net/mlx5e: Send PAOS command on interface up/down Saeed Mahameed
2017-08-17 13:29 ` [net-next 02/15] net/mlx5e: IPoIB, Fix driver name retrieved by ethtool Saeed Mahameed
2017-08-17 13:29 ` [net-next 03/15] net/mlx5e: IPoIB, Add support for get_link_ksettings in ethtool Saeed Mahameed
2017-08-17 13:29 ` [net-next 04/15] net/mlx5: Add PCIe outbound stalls counters infrastructure Saeed Mahameed
2017-08-17 13:29 ` [net-next 05/15] net/mlx5e: Add PCIe outbound stalls counters Saeed Mahameed
2017-08-17 13:29 ` [net-next 06/15] net/mlx5: Add RX buffer fullness counters infrastructure Saeed Mahameed
2017-08-17 13:29 ` [net-next 07/15] net/mlx5e: Add RX buffer fullness counters Saeed Mahameed
2017-08-17 13:29 ` [net-next 08/15] net/mlx5e: Add outbound PCI buffer overflow counter Saeed Mahameed
2017-08-17 13:29 ` [net-next 09/15] net/mlx5: Avoid blank lines after/before open/close brace Saeed Mahameed
2017-08-17 13:29 ` [net-next 10/15] net/mlx5: Add a blank line after declarations Saeed Mahameed
2017-08-23 22:39 ` Joe Perches
2017-08-24 12:58 ` Saeed Mahameed [this message]
2017-08-17 13:29 ` [net-next 11/15] net/mlx5e: Properly indent within conditional statements Saeed Mahameed
2017-08-17 14:18 ` David Laight
2017-08-17 15:35 ` Saeed Mahameed
2017-08-17 17:21 ` David Miller
2017-08-17 13:30 ` [net-next 12/15] net/mlx5e: Avoid using multiple blank lines Saeed Mahameed
2017-08-17 13:30 ` [net-next 13/15] net/mlx5e: Place constants on the right side of comparisons Saeed Mahameed
2017-08-17 13:30 ` [net-next 14/15] net/mlx5e: Use kernel types instead of uint*_t in ethtool callbacks Saeed Mahameed
2017-08-17 13:30 ` [net-next 15/15] net/mlx5e: Use size_t to store byte offset in statistics descriptors Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALzJLG9GOgzOOOM+shw4ECxp6XcteePyBmo6V47_sF=YDYEidA@mail.gmail.com' \
--to=saeedm@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=leonro@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).