From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
David Miller <davem@davemloft.net>,
Hannes Frederic Sowa <hannes@redhat.com>,
Netdev <netdev@vger.kernel.org>,
Matthew Finlay <matt@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: mlx5e throwing RTNL_ASSERT error on vxlan_get_rx_port
Date: Fri, 22 Apr 2016 23:02:05 +0300 [thread overview]
Message-ID: <CALzJLG9JG19GhqWoMZonwxaubUeiw-wvZfKXCv6uxYEq3GLRNA@mail.gmail.com> (raw)
In-Reply-To: <CAKgT0Ud2yc3ZgMpSwdWAvaJ6b2-Q5QO=SEOb709y1BHepU_rQw@mail.gmail.com>
On Fri, Apr 22, 2016 at 10:30 PM, Alexander Duyck
<alexander.duyck@gmail.com> wrote:
> From what I can tell it looks like the recent commit that changed the
> behavior for vxlan_get_rx_port has broken the mlx5 driver as it was
> calling vxlan_get_rx_port in mlx5e_create_netdev which didn't hold the
> rtnl lock. As a result it is throwing RTNL_ASSERT errors.
>
Nice catch Alex.
> I'm not sure if anyone has already seen this or not but I thought I
> would bring it to your attention. Odds are this probably something
> that needs to be fixed in the mlx5e driver and if I have time I might
> get to it sometime in the next several days if nobody else ends up
> addressing it.
>
Matt will handle it, he is already preparing two fixes in mlx5 vxlan
area, one is to address the kconfig issue Arnd reported and the other
is to address the scheduling while atomic in mlx5e_vxlan_add ndo
implementation which can sleep, from vxlan module it is called under
rcu_read_lock.
Thanks,
Saeed
next prev parent reply other threads:[~2016-04-22 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 19:30 mlx5e throwing RTNL_ASSERT error on vxlan_get_rx_port Alexander Duyck
2016-04-22 20:02 ` Saeed Mahameed [this message]
2016-04-25 9:07 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALzJLG9JG19GhqWoMZonwxaubUeiw-wvZfKXCv6uxYEq3GLRNA@mail.gmail.com \
--to=saeedm@dev.mellanox.co.il \
--cc=alexander.duyck@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hannes@redhat.com \
--cc=matt@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).