From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saeed Mahameed Subject: Re: mlx5e throwing RTNL_ASSERT error on vxlan_get_rx_port Date: Fri, 22 Apr 2016 23:02:05 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Saeed Mahameed , David Miller , Hannes Frederic Sowa , Netdev , Matthew Finlay , Yevgeny Petrilin , Arnd Bergmann To: Alexander Duyck Return-path: Received: from mail-yw0-f171.google.com ([209.85.161.171]:36167 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbcDVUCZ (ORCPT ); Fri, 22 Apr 2016 16:02:25 -0400 Received: by mail-yw0-f171.google.com with SMTP id o66so133830430ywc.3 for ; Fri, 22 Apr 2016 13:02:24 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Apr 22, 2016 at 10:30 PM, Alexander Duyck wrote: > From what I can tell it looks like the recent commit that changed the > behavior for vxlan_get_rx_port has broken the mlx5 driver as it was > calling vxlan_get_rx_port in mlx5e_create_netdev which didn't hold the > rtnl lock. As a result it is throwing RTNL_ASSERT errors. > Nice catch Alex. > I'm not sure if anyone has already seen this or not but I thought I > would bring it to your attention. Odds are this probably something > that needs to be fixed in the mlx5e driver and if I have time I might > get to it sometime in the next several days if nobody else ends up > addressing it. > Matt will handle it, he is already preparing two fixes in mlx5 vxlan area, one is to address the kconfig issue Arnd reported and the other is to address the scheduling while atomic in mlx5e_vxlan_add ndo implementation which can sleep, from vxlan module it is called under rcu_read_lock. Thanks, Saeed