From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
To: David Miller <davem@davemloft.net>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>, Tal Alon <talal@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>
Subject: Re: [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero
Date: Thu, 21 Apr 2016 22:01:18 +0300 [thread overview]
Message-ID: <CALzJLG9ZbuwmGvuU5t68fYuErCUXU4c7_cf3n7O397EM06sWJg@mail.gmail.com> (raw)
In-Reply-To: <20160421.140454.143155848960923980.davem@davemloft.net>
On Thu, Apr 21, 2016 at 9:04 PM, David Miller <davem@davemloft.net> wrote:
> From: Saeed Mahameed <saeedm@mellanox.com>
> Date: Tue, 19 Apr 2016 15:33:42 +0300
>
>> Upon ethtool request to set speed to 0 we handle it as a special request
>> to reset link modes to Device's defaults.
>>
>> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4
>> Ethernet functionality")
>> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
>
> Please don't try to sneak things like this into the patches you submit.
>
No one is trying to sneak things here, This patch is transparent
enough and well documented, it is not fair to call it "sneaking" !
I am glad this is what you think about the patch, but i am a little
bit stunned of what you think about me .
> If you continue to add weird stuff like this, I will never _ever_ be
> able to trust you guys and have a high degree of confidence in your
> changes. If you continue like this, I will always have to audit your
> patches very strictly which is very time consuming for me.
>
Well i wanted to argue on why i think it is ok to treat speed=0 as
special reset request, but I also kinda agree with you on this, I
won't waste more of your time on this.
I hope I won't disappoint you in the future, after all we learn from the best.
> Do not extend ethtool's semantics in a way which suits you specifically.
>
> If we want to have this semantic, you must first propose it as a
> global semantic which then in turn can be adopted by all drivers
> supporting ethtool.
>
Sure thing, will drop this patch now, and will improve it later.
Thank you.
prev parent reply other threads:[~2016-04-21 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 12:33 [PATCH net 0/9] mlx5 driver updates and fixes Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 1/9] net/mlx5_core: Fix soft lockup in steering error flow Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 2/9] net/mlx5e: Fix MLX5E_100BASE_T define Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 3/9] net/mlx5_core: Add ConnectX-5 to list of supported devices Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 4/9] net/mlx5e: Device's mtu field is u16 and not int Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 5/9] net/mlx5e: Fix minimum MTU Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 6/9] net/mlx5e: Use vport MTU rather than physical port MTU Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 7/9] net/mlx5_core: Remove static from local variable Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 8/9] net/mlx5: Add pci shutdown callback Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero Saeed Mahameed
2016-04-21 18:04 ` David Miller
2016-04-21 18:07 ` David Miller
2016-04-21 19:01 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALzJLG9ZbuwmGvuU5t68fYuErCUXU4c7_cf3n7O397EM06sWJg@mail.gmail.com \
--to=saeedm@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).