From mboxrd@z Thu Jan  1 00:00:00 1970
From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Subject: Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c
Date: Fri, 27 Jul 2018 14:17:26 -0700
Message-ID: <CALzJLG_okre=gaU4RT-kC0vsHuhnaO-pQTidW3ediSTBj73ZnQ@mail.gmail.com>
References: <20180715190628.23508-1-kamalheib1@gmail.com> <CALzJLG9mmtcyEapLSSU4Y2JEBCiOqLi3ns4EAhVpJsTxT1iNLw@mail.gmail.com>
 <20180727155940.GA12305@kheib-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "David S . Miller" <davem@davemloft.net>,
        Saeed Mahameed <saeedm@mellanox.com>,
        Linux Netdev List <netdev@vger.kernel.org>
To: Kamal Heib <kamalheib1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lj1-f195.google.com ([209.85.208.195]:43716 "EHLO
        mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2389659AbeG0Wla (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 27 Jul 2018 18:41:30 -0400
Received: by mail-lj1-f195.google.com with SMTP id r13-v6so5550031ljg.10
        for <netdev@vger.kernel.org>; Fri, 27 Jul 2018 14:17:47 -0700 (PDT)
In-Reply-To: <20180727155940.GA12305@kheib-laptop>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Jul 27, 2018 at 8:59 AM, Kamal Heib <kamalheib1@gmail.com> wrote:
> On Thu, Jul 26, 2018 at 11:51:49AM -0700, Saeed Mahameed wrote:
>> On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib <kamalheib1@gmail.com> wrot=
e:
>> > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's
>> > only used there.
>> >
>> > Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags infra=
structure")
>> > Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
>> > ---
>> >  drivers/net/ethernet/mellanox/mlx5/core/en.h         | 7 -------
>> >  drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 7 +++++++
>> >  2 files changed, 7 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/ne=
t/ethernet/mellanox/mlx5/core/en.h
>> > index eb9eb7aa953a..84e6a5b42286 100644
>> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
>> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
>> > @@ -208,13 +208,6 @@ struct mlx5e_umr_wqe {
>> >
>> >  extern const char mlx5e_self_tests[][ETH_GSTRING_LEN];
>> >
>> > -static const char mlx5e_priv_flags[][ETH_GSTRING_LEN] =3D {
>> > -       "rx_cqe_moder",
>> > -       "tx_cqe_moder",
>> > -       "rx_cqe_compress",
>> > -       "rx_striding_rq",
>> > -};
>> > -
>>
>> Hi Kamal, on a second thought, i would like to drop this change and
>> keep mlx5e_priv_flags close/local to the below mlx5e_priv_flag.
>>
>> Please let me know.
>>
>
> Hi,
>
> Basically this change came to avoid the following warning when compiling
> the mlx5 driver with "W=3D1" flag and this error will appear for each
> file that include the "en.h".
>
> So, I suggest not drop this change.
>
> In file included from drivers/net/ethernet/mellanox/mlx5/core//en_main.c:=
40:0:
> drivers/net/ethernet/mellanox/mlx5/core//en.h:206:19: warning: =E2=80=98m=
lx5e_priv_flags=E2=80=99 defined but not used [-Wunused-const-variable=3D]
>  static const char mlx5e_priv_flags[][ETH_GSTRING_LEN] =3D {
>

Ok Kamal,
Patch applied to net-next-mlx5.

Thank you !