From: saeed bishara <saeed.bishara@gmail.com>
To: Joseph Gasparakis <joseph.gasparakis@intel.com>
Cc: davem@davemloft.net, shemminger@vyatta.com, chrisw@sous-sol.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry@broadcom.com,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH v2 1/3] net: Add support for hardware-offloaded encapsulation
Date: Mon, 12 Nov 2012 14:31:05 +0200 [thread overview]
Message-ID: <CAMAG_ecK1eUEcCD49DxSzCEqEHwd8qzJPvs3uK+FBW2MMwkV8w@mail.gmail.com> (raw)
In-Reply-To: <1352709418-28996-2-git-send-email-joseph.gasparakis@intel.com>
> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
> index 5ac3212..6dd59a5 100644
> --- a/include/linux/netdev_features.h
> +++ b/include/linux/netdev_features.h
> NETIF_F_RXCSUM_BIT, /* Receive checksumming offload */
> + NETIF_F_RXCSUM_ENC_BIT, /* Receive checksuming offload */
> + /* for encapsulation */
in the future more features will be needed for tunneled packets (tso,
rxhash, etc..)
so I think it would make sense to add a new features variable for
tunneled packets, and the enum above will be used as is.
for example, if the driver supports checksum offloading for
encapsulated packets, then it will set the RXCSUM_BIT in that
variable:
netdev->encap_hw_features = NETIF_F_RXCSUM_BIT;
saeed
next prev parent reply other threads:[~2012-11-12 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 8:36 [PATCH v2 net-next 0/3 ] tunneling: Add support for hardware-offloaded encapsulation Joseph Gasparakis
2012-11-12 8:36 ` [PATCH v2 1/3] net: " Joseph Gasparakis
2012-11-12 12:31 ` saeed bishara [this message]
2012-11-12 8:36 ` [PATCH v2 2/3] vxlan: capture inner headers during encapsulation Joseph Gasparakis
2012-11-12 8:36 ` [PATCH v2 3/3] ipgre: " Joseph Gasparakis
2012-11-12 11:20 ` Dmitry Kravkov
2012-11-14 0:42 ` [PATCH v2 net-next 0/3 ] tunneling: Add support for hardware-offloaded encapsulation Joseph Gasparakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMAG_ecK1eUEcCD49DxSzCEqEHwd8qzJPvs3uK+FBW2MMwkV8w@mail.gmail.com \
--to=saeed.bishara@gmail.com \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=joseph.gasparakis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).