Re: [PATCH v2] net: add calxeda xgmac ethernet driver

[saeed bishara <saeed.bishara@gmail.com>]

On Sun, Oct 30, 2011 at 11:30 PM, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@calxeda.com>
Hi Rob, one more comment
>


> +static void xgmac_tx_complete(struct xgmac_priv *priv)
> +{
> +       void __iomem *ioaddr = priv->base;
> +
> +
> +       writel(DMA_STATUS_TU | DMA_STATUS_NIS, ioaddr + XGMAC_DMA_STATUS);
> +
> +       while (dma_ring_cnt(priv->tx_head, priv->tx_tail, DMA_TX_RING_SZ)) {
> +               unsigned int entry = priv->tx_tail;
> +               struct sk_buff *skb = priv->tx_skbuff[entry];
> +               struct xgmac_dma_desc *p = priv->dma_tx + entry;
> +
> +               /* Check if the descriptor is owned by the DMA. */
> +               if (desc_get_owner(p))
> +                       break;
> +
> +               /* Verify tx error by looking at the last segment */
> +               if (desc_get_tx_ls(p))
> +                       desc_get_tx_status(priv, p);
> +
> +               netdev_dbg(priv->dev, "tx ring: curr %d, dirty %d\n",
> +                       priv->tx_head, priv->tx_tail);
> +
> +               dma_unmap_single(priv->device, desc_get_buf_addr(p),
> +                                desc_get_buf_len(p), DMA_TO_DEVICE);
I think you missed to do dma_unmap_page for the skp frags page.
saeed