Re: [PATCH v2 net-next] eth: bnxt: add netmem TX support

[Taehee Yoo <ap420073@gmail.com>]

On Thu, Jun 19, 2025 at 2:21 AM Michael Chan <michael.chan@broadcom.com> wrote:
>

Hi Michael,
Thanks a lot for the review :)

> On Wed, Jun 18, 2025 at 6:54 AM Taehee Yoo <ap420073@gmail.com> wrote:
> >
> > Use netmem_dma_*() helpers and declare netmem_tx to support netmem TX.
> > By this change, all bnxt devices will support the netmem TX.
> >
> > Unreadable skbs are not going to be handled by the TX push logic.
> > So, it checks whether a skb is readable or not before the TX push logic.
> >
> > netmem TX can be tested with ncdevmem.c
> >
> > Acked-by: Mina Almasry <almasrymina@google.com>
> > Acked-by: Stanislav Fomichev <sdf@fomichev.me>
> > Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> > ---
> >
> > v2:
> >  - Fix commit message.
> >  - Add Ack tags from Mina and Stanislav.
> >
>
> Thanks for the patch.  At a quick glance, it seems that the netmem dma
> unmap is missing in __bnxt_tx_int().

Thanks! I will change unmaps in __bnxt_in_int() in the v3.

Thanks a lot!
Taehee Yoo