From: Taehee Yoo <ap420073@gmail.com>
To: Pravin Shelar <pshelar@ovn.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
ovs dev <dev@openvswitch.org>
Subject: Re: [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom
Date: Tue, 16 Jul 2019 21:28:30 +0900 [thread overview]
Message-ID: <CAMArcTVFYYZy2XWZCTFQvZBzpSYf7_-e1Mu27-yhhTPeoeiBfw@mail.gmail.com> (raw)
In-Reply-To: <CAOrHB_DXSo37ZttVcW3fEuvB9_-2VtzZgf0JNq1ZhSfJJHSa7Q@mail.gmail.com>
On Tue, 16 Jul 2019 at 03:15, Pravin Shelar <pshelar@ovn.org> wrote:
>
Hi Pravin,
> On Fri, Jul 5, 2019 at 9:08 AM Taehee Yoo <ap420073@gmail.com> wrote:
> >
> > When a vport is deleted, the maximum headroom size would be changed.
> > If the vport which has the largest headroom is deleted,
> > the new max_headroom would be set.
> > But, if the new headroom size is equal to the old headroom size,
> > updating routine is unnecessary.
> >
> > Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>
> Sorry for late reply. This patch looks good to me too.
>
> I am curious about reason to avoid adjustment to headroom. why are you
> trying to avoid unnecessary changes to headroom.
>
Thank you for the review!
The intention of this patch is to remove unnecessary overhead.
There is no other reason.
Thanks!
> Thanks,
> Pravin.
prev parent reply other threads:[~2019-07-16 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 16:08 [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom Taehee Yoo
2019-07-08 23:08 ` David Miller
2019-07-08 23:18 ` [ovs-dev] " Gregory Rose
2019-07-08 23:22 ` Gregory Rose
2019-07-11 21:07 ` Pravin Shelar
2019-07-11 23:55 ` Gregory Rose
2019-07-12 16:18 ` Gregory Rose
2019-07-12 22:18 ` David Miller
2019-07-12 23:11 ` Gregory Rose
2019-07-15 18:15 ` Pravin Shelar
2019-07-16 12:28 ` Taehee Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMArcTVFYYZy2XWZCTFQvZBzpSYf7_-e1Mu27-yhhTPeoeiBfw@mail.gmail.com \
--to=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).