From mboxrd@z Thu Jan 1 00:00:00 1970 From: Taehee Yoo Subject: Re: [PATCH nf-next] netfilter: nft_reject_bridge: remove unnecessary ttl set Date: Tue, 12 Jun 2018 01:54:05 +0900 Message-ID: References: <20180611163505.9827-1-ap420073@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: netdev@vger.kernel.org, Taehee Yoo To: davem@davemloft.net, Steffen Klassert Return-path: Received: from mail-ot0-f194.google.com ([74.125.82.194]:38735 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933954AbeFKQyG (ORCPT ); Mon, 11 Jun 2018 12:54:06 -0400 Received: by mail-ot0-f194.google.com with SMTP id n3-v6so24585837ota.5 for ; Mon, 11 Jun 2018 09:54:06 -0700 (PDT) In-Reply-To: <20180611163505.9827-1-ap420073@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: 2018-06-12 1:35 GMT+09:00 Taehee Yoo : > In the nft_reject_br_send_v4_tcp_reset(), a ttl is set by > the nf_reject_ip_tcphdr_put(). so, below code is unnecessary. > > Signed-off-by: Taehee Yoo > --- > net/bridge/netfilter/nft_reject_bridge.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bridge/netfilter/nft_reject_bridge.c b/net/bridge/netfilter/nft_reject_bridge.c > index eaf05de..e0b082c 100644 > --- a/net/bridge/netfilter/nft_reject_bridge.c > +++ b/net/bridge/netfilter/nft_reject_bridge.c > @@ -89,8 +89,7 @@ static void nft_reject_br_send_v4_tcp_reset(struct net *net, > niph = nf_reject_iphdr_put(nskb, oldskb, IPPROTO_TCP, > net->ipv4.sysctl_ip_default_ttl); > nf_reject_ip_tcphdr_put(nskb, oldskb, oth); > - niph->ttl = net->ipv4.sysctl_ip_default_ttl; > - niph->tot_len = htons(nskb->len); > + niph->tot_len = htons(nskb->len); > ip_send_check(niph); > > nft_reject_br_push_etherhdr(oldskb, nskb); > -- > 2.9.3 > I'm so sorry, I sent this to you by mistake. Please ignore this. Thanks