Re: [PATCH bpf-next v5 12/13] selftests/bpf: Add a bpf fq qdisc to selftest

[Amery Hung <ameryhung@gmail.com>]

On Fri, Mar 14, 2025 at 8:35 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Thu, Mar 13, 2025 at 12:03 PM Amery Hung <ameryhung@gmail.com> wrote:
> >
> > From: Amery Hung <amery.hung@bytedance.com>
> >
> > This test implements a more sophisticated qdisc using bpf. The bpf fair-
> > queueing (fq) qdisc gives each flow an equal chance to transmit data. It
> > also respects the timestamp of skb for rate limiting.
> >
> > Signed-off-by: Amery Hung <amery.hung@bytedance.com>
> > ---
> >  .../selftests/bpf/prog_tests/bpf_qdisc.c      |  24 +
> >  .../selftests/bpf/progs/bpf_qdisc_fq.c        | 718 ++++++++++++++++++
>
> On the look of it, it's a pretty functional qdisc.
> Since bpftool supports loading st_ops,
> please list commands bpftool and tc the one can enter
> to use this qdisc without running selftests.
>

Thanks for the suggestion. That should be very helpful. I will add the commands.

> Probably at the comment section at the top of bpf_qdisc_fq.c
>
> It also needs SPDX and copyright.

I will add SPDX and copyright as well.

Thanks,
Amery

>
> pw-bot: cr