From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f52.google.com ([209.85.218.52]:43926 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbeB1OxL (ORCPT ); Wed, 28 Feb 2018 09:53:11 -0500 Received: by mail-oi0-f52.google.com with SMTP id a207so1935475oii.10 for ; Wed, 28 Feb 2018 06:53:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180228.094147.1456557446129712432.davem@davemloft.net> References: <1518489840-27911-1-git-send-email-xiangxia.m.yue@gmail.com> <20180213.121946.1379751706930638939.davem@davemloft.net> <20180228.094147.1456557446129712432.davem@davemloft.net> From: Tonghao Zhang Date: Wed, 28 Feb 2018 22:53:10 +0800 Message-ID: Subject: Re: [PATCH] tcp: Support tcp socket allocated counter in namespace. To: David Miller Cc: Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Feb 28, 2018 at 10:41 PM, David Miller wrote: > From: Tonghao Zhang > Date: Wed, 28 Feb 2018 21:01:52 +0800 > >>> The amount of new conditional tests in these fast paths are not >>> justified for this new counter which is of debatable usefullness. >> sorry, too late for reply. Did you mean this counter will affect performance ? >> I tested the patch witch netperf. > > A single flow TCP session with no loss doesn't tell us much. > > I just know from how these things go that under load, and with > all kinds of different flows with different characterstics, > every conditional test in the fast paths matter. > > If you want to have a chance at your change getting accepted, > running all kinds of benchmarks won't do it. > > Instead, please find a way to make your feature work without all of > the newly added tests (whilst not adding another cost at the same > time). Thanks for your explanation. > Thank you.