From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C28222C3244 for ; Mon, 2 Jun 2025 17:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748883713; cv=none; b=fcyL+V490dA7LwYG4bH/IVkmbM4noCyupqF+3jdyvfnY15ODdoAA/eC+3gmHFy3Oc5J3vzTxtwTBndbr+vSNE7H+xiIJH15RJ8mrZVst/UJXQ4W2/kh8CTEC1EOherphyuHBpW5pH5uVvnwsKMGUwKODCuxQow+44/uikluuJoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748883713; c=relaxed/simple; bh=HH4IZh2wZ91YFwtu/TN9O0Wjnf2tiVrksx+dUNEHZxc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mg52k1ojTMIUacW5PUodFLRSbdrXb2KJHPNmlpVhJdJsQCueMZhp09uyJyc01YRWwWgtdVCPvFu8+Znzmc5W01E8zVVPZZopmCGiis0M1AH57hewersqyg3NoRziv5FiP4a0M9Nmmou23EmAWSdoWePEnnq0anx3NGlJRlqWOP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smile.fr; spf=pass smtp.mailfrom=smile.fr; dkim=pass (1024-bit key) header.d=smile.fr header.i=@smile.fr header.b=Q0pP/Un4; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smile.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smile.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=smile.fr header.i=@smile.fr header.b="Q0pP/Un4" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6049431b0e9so7520895a12.0 for ; Mon, 02 Jun 2025 10:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile.fr; s=google; t=1748883708; x=1749488508; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=abDph0Aj5XQN6In+Lzu8X3Vm8VPqLMwLrdQIcHgjTyU=; b=Q0pP/Un4szZNC3IOfyP//MC8RoLsqa8BX7cQHeshkk0oVJI+cLH9PJdgpdO9ODD6HI AAPjPQAyRm0xOR/G2x6bwQdD9PoG07dBQx2mgb06Wppq62s1k0nxpr/iBvzMchPvL9tU yg0p7MIamF3ze7r7R6XGcEWGaSujGVikGwHJA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748883708; x=1749488508; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=abDph0Aj5XQN6In+Lzu8X3Vm8VPqLMwLrdQIcHgjTyU=; b=sVA68J4VBfhZ1BxAVowIp8ijE5cGMzY5YUTLDRCoGg1nvbOcHZZAjTQXeh5LxAfg6p osu2gb8tziK47v0wMZDztp1LX3vHuOdg2n4aU8nYg6TjxkcFJ660jjm68TJq8Pvonnw1 8z/x5Zv0ADegRMIVBoSYxpDNb8AGCXtmhFVzZzGT72o//DcfkkXHk5DwgKxzqTgbyG8d modTQZdOHEsLDRdKpk+BAU6rzVJkrj1wmKUIPLtn0/Be62rORP+SwPlec2x7bgUdJpTq 1rV30ScsjXHQ7VG1RjTfMm/LhM4k631zczw1jqJzd/nNQtmN1yFWQMMw0/jUB4n994Eg asWw== X-Forwarded-Encrypted: i=1; AJvYcCUXnt+k9gFZ0YsHcYswm4gebdS7RGK1M4j6p/Uk5uEh07XYRo7HxyA996K5CykM7PGM5VMAvq4=@vger.kernel.org X-Gm-Message-State: AOJu0YwvPq0OR9VdMa7SF2gxtlaOUd31K14VgCONGH9Q8f13KOXNJWeh 2qvlb4lgXL+ey9SdcWEyzURQw9iLCqh5C39+k1J2xcQQSOnn4CwGtzX3mtl6C1ONi8RwLV2pFO0 Ro39qFdxEjq1Z+Fm+uwibUd4om2/jG+38/FwvcVTORg== X-Gm-Gg: ASbGncv5y2PkJ6toPmAyvfGcbv+xWdaskEyMHmPH0PAv7yA21ByxznWcsXjix8CcnJn jSsTAthIHhb+HboLw8ZVXfYiwDEmN4rbu4jduviSIAAciMYdC8n181lly3QRXslIRLLaP//LEzV Kvg1jrepclD/dezTcvm4fwzB/kcBW0uU1P7PgYDoPbM2Y= X-Google-Smtp-Source: AGHT+IG76GcE0CyIGvdYC6symGR++l6I7RyOq2ODj2VjqbpsYHvlsULDDGdmeG91WwsK5n6zSyCNIMvbwaUqpWiOWN8= X-Received: by 2002:a05:6402:280f:b0:602:3e6d:9334 with SMTP id 4fb4d7f45d1cf-6057c628879mr10562013a12.24.1748883707841; Mon, 02 Jun 2025 10:01:47 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250528203152.628818-1-corentin.guillevic@smile.fr> <174846881248.859527.7504198795486149705.robh@kernel.org> In-Reply-To: <174846881248.859527.7504198795486149705.robh@kernel.org> From: Corentin GUILLEVIC Date: Mon, 2 Jun 2025 19:01:37 +0200 X-Gm-Features: AX0GCFuEbqSxAst_bXA7BoLSAfRzF9ne8TSDsrwoFAMFO0l0IJqCz-SKpTzZj5U Message-ID: Subject: Re: [PATCH] dt-bindings: net: dsa: microchip: add bit-banged SMI example To: "Rob Herring (Arm)" Cc: devicetree@vger.kernel.org, Jakub Kicinski , netdev@vger.kernel.org, "David S. Miller" , Andrew Lunn , Marek Vasut , Krzysztof Kozlowski , Vladimir Oltean , Woojung Huh , Conor Dooley , UNGLinuxDriver@microchip.com, Paolo Abeni , linux-kernel@vger.kernel.org, Eric Dumazet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mer. 28 mai 2025 =C3=A0 23:46, Rob Herring (Arm) a =C3= =A9crit : > > > On Wed, 28 May 2025 22:31:51 +0200, Corentin Guillevic wrote: > > KSZ8863 can be configured using I2C, SPI or Microchip SMI. The latter i= s > > similar to MDIO, but uses a different protocol. If the hardware doesn't > > support this, SMI bit banging can help. This commit adds an device tree > > example that uses the CONFIG_MDIO_GPIO driver for SMI bit banging. > > > > Signed-off-by: Corentin Guillevic > > --- > > .../bindings/net/dsa/microchip,ksz.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml:246:1: [er= ror] missing document start "---" (document-start) > ./Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml:246:3: [er= ror] syntax error: expected '', but found '' (syntax) > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/n= et/dsa/microchip,ksz.yaml: ignoring, error parsing file > Traceback (most recent call last): > File "/usr/bin/yamllint", line 33, in > sys.exit(load_entry_point('yamllint=3D=3D1.29.0', 'console_scripts', = 'yamllint')()) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^= ^^^^^^^^^ > File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 228, in run > prob_level =3D show_problems(problems, file, args_format=3Dargs.forma= t, > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/usr/lib/python3/dist-packages/yamllint/cli.py", line 113, in sho= w_problems > for problem in problems: > File "/usr/lib/python3/dist-packages/yamllint/linter.py", line 200, in = _run > for problem in get_cosmetic_problems(buffer, conf, filepath): > File "/usr/lib/python3/dist-packages/yamllint/linter.py", line 137, in = get_cosmetic_problems > for problem in rule.check(rule_conf, > File "/usr/lib/python3/dist-packages/yamllint/rules/indentation.py", li= ne 583, in check > yield from _check(conf, token, prev, next, nextnext, context) > File "/usr/lib/python3/dist-packages/yamllint/rules/indentation.py", li= ne 344, in _check > if expected < 0: > ^^^^^^^^^^^^ > TypeError: '<' not supported between instances of 'NoneType' and 'int' > ./Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml:246:3: but= found another document > make[2]: *** Deleting file 'Documentation/devicetree/bindings/net/dsa/mic= rochip,ksz.example.dts' > Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml:246:3: but f= ound another document > make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentatio= n/devicetree/bindings/net/dsa/microchip,ksz.example.dts] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1524: dt_bin= ding_check] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202505= 28203152.628818-1-corentin.guillevic@smile.fr > > The base for the series is generally the latest rc1. A different dependen= cy > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your sch= ema. > Sorry,.. I send a fixed one. Regards, Corentin