From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BCB639AEB for ; Tue, 11 Jun 2024 20:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718136371; cv=none; b=OWeKuFrBmL5gkJ1ImMt6d/WNuxT0+4gvOQ0hYQJLSmi9VLFaFCsEzkKbdR39CXN3vaZ41lSbpEbY9M/JXnc/Plqgl5RxqLAYkN4Qg+/UEd8qRQuDNuIbTGu5E3OrSArI0H49G+7XggDbpjNF72FcwFiMl5O1oFCRo/kPIC4ce0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718136371; c=relaxed/simple; bh=uHnbK8yZ9GQzrqt+GVlF51JCkKEzN8ZWdF3jcm+f9eQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=P6RYxWIXacB+3YQWo7NcQn6QT6zxgOzo7n9P0MiwN7C2I/I+8meIWkQb5un7d0aBgDFtS0cd/gUObWm1n1tH9Ml6rqZYKzBlmeXtgAOCzFIhr35+3/43kwMXs69HQ5suR8oNGZSynvB1G5Uv9LD49Tppk8lprbdtSlEJJkWCHGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lDXiPaFK; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lDXiPaFK" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-52c7f7fdd24so1964742e87.1 for ; Tue, 11 Jun 2024 13:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1718136368; x=1718741168; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uHnbK8yZ9GQzrqt+GVlF51JCkKEzN8ZWdF3jcm+f9eQ=; b=lDXiPaFKuovlZYK3il23Wg5MewPD2fut+IdNs/xXt0jIgm2xmMmXE+y/fre4x5GqsK NCzmzTar6Jw99zD8UuilH6uG+Xrp5Ioy6EYHtsVSlTNDAarndn3Zo3iXaaUX1HOfANdK UC+Je0/6JHMDLlVvLVR9JUTNs7qMwjAJHnKonfbs8bi3SyVQxyVR45PWiIGjpqbyMK40 l7ip7rsasFHt3X+04ngrpj+uIV5xcl0AROL14tuQcFiuT/J3dm+qMI/WtYbTgLh+PuNv Ec6B7rIKumfUJ0WwrMChJHnq2CMqtDgu+O8eJ3USHaI8+SL6lsZoxBG0jEcMBWvWiSO0 YeGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718136368; x=1718741168; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uHnbK8yZ9GQzrqt+GVlF51JCkKEzN8ZWdF3jcm+f9eQ=; b=gEEw54Z/8P7TFOck1rs1eJvN6Hew83oU6DgCtuC7WTUbEOr29sj/Y3YVm7Ovp2NUiV aRUrItkXNR9WpGmUY9hdRNzCQNHJWMnSExlSWlXopAHQs3vYFyNhgQci+VAGxc00e851 sBp5d7VTZ2wQCWbdbKustm2DVQomcexfO5fRLNlf0EvPPc1B19n2QNMncqDLjADrNZpC fkXByawdtQvEw54KlKdq1E1oBYBvqY9cyP0O3Flc+NslzpGX9xPp42hqKB53DBPkt7PC nDsFx0UgL4XzSktRWM0JyKHmDBj0VQSJSYqsOR6M9Xk3/lTbA9m/aUU22OIVcdnAvvGl ALNg== X-Forwarded-Encrypted: i=1; AJvYcCUpJShnFwjmIrl0UXQbz+vxlKtfbv1daNqlchIVLa+aDXBWKPJEb6Iu8a3FEAbEveYnb5O/YzRcaeLfbGKIhhaoVIBupA5t X-Gm-Message-State: AOJu0YzV7wOziWnFdkrAv1eBbEh9B5H2OXN+EBm28C64VOekRVP9zHCb iZYq5u+arkxq5HHkPHo8tVb/vXl+9oK4b9gUcAfwrt7tK2sEPi6KxOSFYVcduCc1/udjzJ7J+ki xRkN1XQzdB5vHkUFVV/xL9C0xEd3tvNeaTTcC/w== X-Google-Smtp-Source: AGHT+IHo2kDMYmvh1Fiuq6Vp0TjSyMZ5wd2GkAYNc1OHzZu/lwJY6vNBizdeJ06QMzbe9upl8ARaKOiKysYnJKD3dmc= X-Received: by 2002:ac2:5148:0:b0:52c:5f12:5317 with SMTP id 2adb3069b0e04-52c5f1256a6mr5730643e87.44.1718136368542; Tue, 11 Jun 2024 13:06:08 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240605122106.23818-1-brgl@bgdev.pl> <20240605122106.23818-2-brgl@bgdev.pl> <87h6e6qjuh.fsf@kernel.org> <871q5aqiei.fsf@kernel.org> <87sexqoxm9.fsf@kernel.org> <8db01c97-1cb2-4a86-abff-55176449e264@kernel.org> In-Reply-To: <8db01c97-1cb2-4a86-abff-55176449e264@kernel.org> From: Bartosz Golaszewski Date: Tue, 11 Jun 2024 22:05:57 +0200 Message-ID: Subject: Re: [PATCH v9 1/2] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 To: Krzysztof Kozlowski Cc: Kalle Valo , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org, Bartosz Golaszewski , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 7, 2024 at 8:40=E2=80=AFAM Krzysztof Kozlowski wrote: > > Kalle, > All of the devices out there need these supplies, but they are sometimes > provided by generic PCI supply and on-board regulators. Basically your > PCI adapter is not the same as QCA6390 chip on Snapdragon board. > > > > > >> Based on the discussions I have heard only Snapdragon systems who > >> require all this configuration you describe. Of course there can be > >> other systems but I have not heard about those. > >> > > > > DT is not configuration, it is description of actual hardware. It > > doesn't matter if Snapdragon systems are the only ones that actually > > *require* this description to make WLAN/BT functional upstream. The > > chipset would be the same on any PCIe board, it's just that the host > > systems wouldn't need to take care with its power sequence. But for a > > dynamic board like this, you don't need DT. > > > > Correct. > > ... > > > > >>> If your detachable board "just works" then it must be wired in a way > >>> that enables WLAN the moment it's plugged in but this doesn't happen > >>> over PCI. The chipset has a power input and GPIOs to enable each > >>> module. > >> > >> I don't know how the boards are implemented but it could be so. But fr= om > >> host system point of view it's just a regular PCI device. > >> > > > > And you don't need DT anyway for this type of devices. > > Detechable board, like PCI adapter, derives these supplies from generic > PCI whatever-3.3v through additional regulators. All these supplies are > there - on the board. > > > > >>> Also: I doubt you need DT for your detachable board? > >> > >> Sure, I don't need DT but that's not my point. My point is why require > >> these supplies for _all_ devices having PCI id 17cb:1101 (ie. QCA6390) > >> then clearly there are such devices which don't need it? To me that's > >> bad design and, if I'm understanding correctly, prevents use of > >> qcom,ath11k-calibration-variant property. To me having the supplies > >> optional in DT is more approriate. > >> > > > > We require them because *they are physically there*. > > I understand that for all known DT QCA6390 hardware, the supplies should > be provided thus they should be required. If in the future we have > different design or we represent some pluggable PCI card, then: > 1. Probably that PCI card does not need power sequencing, thus no DT > description, > 2. If still needs power sequencing, you can always amend bindings and > un-require the supplies. > > > Best regards, > Krzysztof > Kalle, does the above answer your questions? Are these bindings good to go? Bart