From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA18C3E3DB2 for ; Tue, 17 Mar 2026 14:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773756787; cv=none; b=lqWqSwoSs1SCwsIBC4b+6zez/05cdIfwaQgC9+gomaFnnuIa5ZVMxRSohGujMCr1/atwsP/1J6lWZgcJefF09QNapwqLa42pGYqo4jaSCovVMvJSV2fgdjGhtghnJz1xQpY9Mcoy43nwjQUKetfDY2gBjQUIJ6qyw/4KhzVxRhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773756787; c=relaxed/simple; bh=9QDalKJYBUEDUJPFs8n5F17T6oCLIOfRdQADKKa+dtg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qE8hUtlTn09ckTBbdjSEXFYV/AHbOXXKvpPVQQ24uryxHzQIZKFfS6zisP6roECbdk1Dn2OdUlRLOlzRvbDcIiDrHOTcuNufxX0Uj40YavQC98q5fjkK5uNHp3lbwxV7E8i6WKBSR8nN6SMf9EbE9Ih6xvryy50gyqCQWkQLYQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tZAEscpa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tZAEscpa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A119C2BCB1 for ; Tue, 17 Mar 2026 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773756787; bh=9QDalKJYBUEDUJPFs8n5F17T6oCLIOfRdQADKKa+dtg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tZAEscpa8SCC5cIZ2JquMfgXyJ2cYbjRRZovEZ4pp9iCwMtzoyZvoUvuYiYMbRTYC SnQwovSWExy1qzNu8gKN2Re3kiqbZF6sZmkIooWlWa9EIx1ERfsbgtRs5rZB0SAIxf 3lPrGMQ4Ue2TuM4ia8nL9lBYQlDl9Z6+Gmi7Vne8vrfCzyTk9J2Ck3dsbBaTLAPSfD NPCO+IQ8fm5HTfq9yr/wXF7f1MJldHxMFhyKqH3oTfoTSoTC0Dh5v2G2YRcDRDQgL5 ObXNTsitNLuKk+KvWrgZ9pPDroH39BoYVIyc5TZiwHYdHQ131NS6aY+w9jvXRnJOfo pYQYSw8TEnjrw== Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-38ad26e3992so5511561fa.1 for ; Tue, 17 Mar 2026 07:13:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUJpjgOsVkVWncdMDuUs3pGbsZSjmUejw7uMQ2+Rk0ZQCUkucXyVCrGv1i5gUGnWTgtSN+Des4=@vger.kernel.org X-Gm-Message-State: AOJu0YwPTUq1pFu8mewjCpPIoykum4ARmGPjsaEkeWQK+3XWM2KcGKMI e3NZTlQLH9YE8YASOs0/T2hxNcnab6zUsUqxtTaHQj/RDaJotSwOi24jbcKdC/mXifDwpElJ5Br deLvJWszhc3vHYB54XIlUj3QT0p7Gf6f3IKKk/0VQDQ== X-Received: by 2002:a05:651c:2115:b0:37f:c5ca:a6d4 with SMTP id 38308e7fff4ca-38a89666433mr58706271fa.6.1773756785569; Tue, 17 Mar 2026 07:13:05 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260316-qcom-sa8255p-emac-v9-0-c58934e76ff2@oss.qualcomm.com> <64d282fd94be1546df75d7df5b47eacc0479797a.camel@redhat.com> In-Reply-To: <64d282fd94be1546df75d7df5b47eacc0479797a.camel@redhat.com> From: Bartosz Golaszewski Date: Tue, 17 Mar 2026 15:12:53 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AaiRm52mh793CgOH9S8BNXU-tBYi1I-pfEq9XQjt50faEkjR5xH42aEvJgG19dM Message-ID: Subject: Re: [PATCH net-next v9 0/6] net: stmmac: qcom-ethqos: add support for SCMI power domains To: Radu Rendec Cc: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski , Martin Blumenstingl , Krzysztof Kozlowski , Lad Prabhakar , Konrad Dybcio Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 16, 2026 at 7:31=E2=80=AFPM Radu Rendec wr= ote: > > On Mon, 2026-03-16 at 13:05 +0100, Bartosz Golaszewski wrote: > > Add support for the firmware-managed variant of the DesignWare MAC on > > the sa8255p platform. This series contains new DT bindings and driver > > changes required to support the MAC in the STMMAC driver. > > > > It also reorganizes the ethqos code quite a bit to make the introductio= n > > of power domains into the driver a bit easier on the eye. > > > > The DTS changes will go in separately. > > I'm seeing some weird behavior with this version. The probe part looks > good (but see below), but when I try to bring an interface up, it fails > with ETIMEDOUT. The relevant part of the stack trace leading to the > error is this: > > dwmac4_dma_reset+0x208/0x220 [stmmac] > stmmac_reset+0x2c/0x68 [stmmac] > stmmac_init_dma_engine+0x108/0x400 [stmmac] > stmmac_hw_setup+0x5c/0x538 [stmmac] > __stmmac_open+0xc8/0x2a0 [stmmac] > stmmac_open+0xcc/0x238 [stmmac] > __dev_open+0x138/0x2a8 > > Now dwmac4_dma_reset() is very simple. It sets the soft reset bit in > the DMA_BUS_MODE register, then waits for the hardware to clear it, and > that never happens. > > Now, getting back to the probe part, there is one extra message > (compared to my previous successful test on v7), which I see at the > very end of the probing: > > qcom-ethqos 23040000.ethernet: clk_csr value out of range (0xffffff00 > exceeds mask 0x00000f00), truncating > > This is a sa8775p ride board, so there are two stmmac devices. I only > see that message for the 2nd one, which is also the one I'm trying to > enable, and which fails. > > I realize this may or may not be related to your changes. But there is > no way to test on a SCMI-pd board without them. I'm not sure how > relevant it would be to test on the non-SCMI variant. I'm assuming the > DMA part should work the same way (regardless of SCMI-pd), so if I can > reproduce it there, and since I know it works on mainline Linux (that's > where I tested v7), I could bisect and see which commit in net-next > breaks it. If you don't have any better idea, let me know and I can > try. Meanwhile, I'll keep poking at v9. > Does current net-next on its own still work? Or is the second interface broken even without this series? Bart