From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCFDC46467 for ; Mon, 28 Nov 2022 01:42:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbiK1Bmi (ORCPT ); Sun, 27 Nov 2022 20:42:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbiK1Bmg (ORCPT ); Sun, 27 Nov 2022 20:42:36 -0500 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3303DE02; Sun, 27 Nov 2022 17:42:35 -0800 (PST) Received: by mail-pj1-f47.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so7673570pjo.3; Sun, 27 Nov 2022 17:42:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vugqIFRxCyknBbu9V+wKU89OOIphCVzqPgtGWbeU2e0=; b=3TT8s7sdFoeIYzo3znoz3PAZN7oTBTJbe1Pzw287AalQyi3//jd0miT3JTuvTfhk+1 zwESm+LfCKndgueY38VzdG/BXxCpCTlrfdSa1i4JVWEd3VoY0K5pDmNxgyJOv3DWhSiv pjlCD/JdgdhF0lONyp4sK/ZZMxGmUi5irvXNYbN1VRNrhNZJP0aLSjBVextE+dPvwai3 ARDCnKYX1j5rzG4G8KJhZ3OanhB5rihieMTHYA/Dl5XDfPrmKfwPEOYOXOJQsBfgY/r1 SyKlemaojdwERPw/V35+Gy8Xbh1DnRC29RJLc1/k/3Mu5pU64EXgIYi4S45fCkgcGEXB NR5Q== X-Gm-Message-State: ANoB5pliEMC+FMs1dFvW6CnM+WfqNAD5U+TQo1rKnk7mnT2TP51lteyn eKk4qoYySY2rCee0wYXzniWTMfH6t3TqR4bc+aY= X-Google-Smtp-Source: AA0mqf5fJFd4OI/wqCAiSyik0VLVFVoFMfzJ9mryfA/1K6FyI90QwUxChWz0UdSQwVRwuYvQMcWJhOKG5dmt/m6SpnU= X-Received: by 2002:a17:90a:77cc:b0:219:1747:f19c with SMTP id e12-20020a17090a77cc00b002191747f19cmr11037058pjs.222.1669599754664; Sun, 27 Nov 2022 17:42:34 -0800 (PST) MIME-Version: 1.0 References: <20221122154934.13937-1-mailhol.vincent@wanadoo.fr> <20221127130919.638324-1-mailhol.vincent@wanadoo.fr> <20221127130919.638324-3-mailhol.vincent@wanadoo.fr> In-Reply-To: From: Vincent MAILHOL Date: Mon, 28 Nov 2022 10:42:23 +0900 Message-ID: Subject: Re: [PATCH net-next v3 2/5] mlxsw: core: fix mlxsw_devlink_info_get() to correctly report driver name To: Ido Schimmel Cc: Jiri Pirko , netdev@vger.kernel.org, Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org, Boris Brezillon , Arnaud Ebalard , Srujana Challa , Kurt Kanzenbach , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Michael Chan , Ioana Ciornei , Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Taras Chornyi , Saeed Mahameed , Leon Romanovsky , Petr Machata , Simon Horman , Shannon Nelson , drivers@pensando.io, Ariel Elior , Manish Chopra , Jonathan Lemon , Vadim Fedorenko , Richard Cochran , Vadim Pasternak , Shalom Toledo , linux-crypto@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, Jiri Pirko , Herbert Xu , Hao Chen , Guangbin Huang , Minghao Chi , Shijith Thotton , Ido Schimmel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon. 28 Nov. 2022 at 01:17, Ido Schimmel wrote: > On Sun, Nov 27, 2022 at 10:09:16PM +0900, Vincent Mailhol wrote: > > Currently, mlxsw_devlink_info_get() reports the device_kind. The > > device_kind is not necessarily the same as the device_name. For > > example, the mlxsw_i2c implementation sets up the device_kind as > > ic2_client::name in [1] which indicates the type of the device > > s/ic2/i2c/ > > > (e.g. chip name). > > > > Fix it so that it correctly reports the driver name. > > > > [1] mlxsw_i2c_probe() from drivers/net/ethernet/mellanox/mlxsw/i2c.c > > Link: https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/i2c.c#L714 > > Same comment as before. > > Before the series: > > # devlink dev info i2c/2-0048 | grep driver > driver mlxsw_minimal > > After the series: > > # devlink dev info i2c/2-0048 | grep driver > driver mlxsw_minimal ACK. I was overall confused by the device_kind. Thank you for your confirmation. I will drop the first two patches from this series. Yours sincerely, Vincent Mailhol