From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Peter Hong <peter_hong@fintek.com.tw>
Cc: wg@grandegger.com, mkl@pengutronix.de,
michal.swiatkowski@linux.intel.com, Steen.Hegelund@microchip.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, frank.jungclaus@esd.eu,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, hpeter+linux_kernel@gmail.com
Subject: Re: [PATCH V2] can: usb: f81604: add Fintek F81604 support
Date: Sun, 26 Mar 2023 11:30:37 +0900 [thread overview]
Message-ID: <CAMZ6RqLNQG30GJH6OJR6bb4yqACn+HiTMEbhbh19Zok=5njJsQ@mail.gmail.com> (raw)
In-Reply-To: <CAMZ6Rq+xSCLe8CYm6K0CyPABo-Gzrt-JUO7_XGgXum+G8k5FCQ@mail.gmail.com>
On Tue. 23 Mar 2023 at 14:54, Vincent MAILHOL
<mailhol.vincent@wanadoo.fr> wrote:
> Le jeu. 23 mars 2023 à 14:14, Peter Hong <peter_hong@fintek.com.tw> a écrit :
(...)
> > struct f81604_bulk_data {
> > u8 cmd;
> > u8 dlc;
> >
> > union {
> > struct {
> > u8 id1, id2;
> > u8 data[CAN_MAX_DLEN];
> > } sff;
> >
> > struct {
> > u8 id1, id2, id3, id4;
> > u8 data[CAN_MAX_DLEN];
> > } eff;
> > };
> > } __attribute__((packed));
Actually, there is an alias for this attribute. Just use __packed
instead of __attribute__((packed)).
(...)
next prev parent reply other threads:[~2023-03-26 2:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 8:11 [PATCH V2] can: usb: f81604: add Fintek F81604 support Ji-Ze Hong (Peter Hong)
2023-03-21 12:42 ` Steen.Hegelund
2023-03-21 15:50 ` Vincent MAILHOL
2023-03-23 5:11 ` Peter Hong
2023-03-23 5:54 ` Vincent MAILHOL
2023-03-23 9:22 ` Vincent MAILHOL
2023-03-26 2:30 ` Vincent MAILHOL [this message]
2023-03-24 16:13 ` Marc Kleine-Budde
2023-03-26 2:37 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6RqLNQG30GJH6OJR6bb4yqACn+HiTMEbhbh19Zok=5njJsQ@mail.gmail.com' \
--to=mailhol.vincent@wanadoo.fr \
--cc=Steen.Hegelund@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank.jungclaus@esd.eu \
--cc=hpeter+linux_kernel@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter_hong@fintek.com.tw \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).