From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA79C761AF for ; Sun, 26 Mar 2023 02:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbjCZCaw convert rfc822-to-8bit (ORCPT ); Sat, 25 Mar 2023 22:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjCZCav (ORCPT ); Sat, 25 Mar 2023 22:30:51 -0400 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D4EFA5E3; Sat, 25 Mar 2023 19:30:50 -0700 (PDT) Received: by mail-pf1-f173.google.com with SMTP id fb38so3551608pfb.7; Sat, 25 Mar 2023 19:30:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679797850; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=16zeEm3Yx86eXVp/qbGCAi0MIpRJKwJZlSDFwjFpw+o=; b=yfuf8wV8TFo/3D3PUb93rl/hozXz/NwnH/ZzK4Z1uKuRcXRAvdShVvlSKOpPs/CQ6V jTM3+VNnG0Ose5GVRpceMr8mYOSYSBy41tvf659knJCb/EE8WuCZXCLMZgytGs0LA2Lb Fz/TDCa/7vHg+7H7Zzt4JvKB3qchjSbfyJJmkEEW1F0XIke+E7tryUhJ1vsDz6T9Hfh7 JDKK6smfHOPBQ/9pq+1ryDLDAQ3FAFL+Mip8SMleIJ91PJ2+2xogOyHtjV6YkG5LiDm/ WE0MZ4xzGc8l+WMFgOqNO/FP+ok2BgoKw3MpWICGeAphtXpD5WqASSzL0DLdJUrOfK/M tvNw== X-Gm-Message-State: AAQBX9fReYgebGiU4IgpswTMXPNUGBEYIiqDqSs7ZdUItRtkyu9PBu16 lqkD5Q7VjS3XYO6E7sAWdQWAGIfZ9n2XhC65axA= X-Google-Smtp-Source: AKy350ZyiXVXqUs1LdjJV3le8Hl08j5qOc6C8xX3M4B2dQPsX/8enbe0vFReza0cI1e1ZcxpUPerYFKADVSMFKZFQoc= X-Received: by 2002:a63:5f02:0:b0:507:3e33:43e3 with SMTP id t2-20020a635f02000000b005073e3343e3mr1874010pgb.7.1679797849615; Sat, 25 Mar 2023 19:30:49 -0700 (PDT) MIME-Version: 1.0 References: <20230321081152.26510-1-peter_hong@fintek.com.tw> In-Reply-To: From: Vincent MAILHOL Date: Sun, 26 Mar 2023 11:30:37 +0900 Message-ID: Subject: Re: [PATCH V2] can: usb: f81604: add Fintek F81604 support To: Peter Hong Cc: wg@grandegger.com, mkl@pengutronix.de, michal.swiatkowski@linux.intel.com, Steen.Hegelund@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, frank.jungclaus@esd.eu, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, hpeter+linux_kernel@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue. 23 Mar 2023 at 14:54, Vincent MAILHOL wrote: > Le jeu. 23 mars 2023 à 14:14, Peter Hong a écrit : (...) > > struct f81604_bulk_data { > > u8 cmd; > > u8 dlc; > > > > union { > > struct { > > u8 id1, id2; > > u8 data[CAN_MAX_DLEN]; > > } sff; > > > > struct { > > u8 id1, id2, id3, id4; > > u8 data[CAN_MAX_DLEN]; > > } eff; > > }; > > } __attribute__((packed)); Actually, there is an alias for this attribute. Just use __packed instead of __attribute__((packed)). (...)