[PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
@ 2023-10-12  4:35 Muhammad Muzammil
  2023-10-12  6:17 ` Muhammad Muzammil
  2023-10-12 17:03 ` Loic Poulain
  0 siblings, 2 replies; 6+ messages in thread
From: Muhammad Muzammil @ 2023-10-12  4:35 UTC (permalink / raw)
  To: horms, loic.poulain, ryazanov.s.a; +Cc: netdev, linux-kernel, Muhammad Muzammil

resolved typing mistake from devce to device

changes since v1:
	- resolved another typing mistake from concurent to
	  concurrent

Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
---
 drivers/net/wwan/wwan_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 87df60916960..72e01e550a16 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
 
 static const struct {
 	const char * const name;	/* Port type name */
-	const char * const devsuf;	/* Port devce name suffix */
+	const char * const devsuf;	/* Port device name suffix */
 } wwan_port_types[WWAN_PORT_MAX + 1] = {
 	[WWAN_PORT_AT] = {
 		.name = "AT",
@@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
 	 */
 	put_device(&wwandev->dev);
 
-	rtnl_lock();	/* Prevent concurent netdev(s) creation/destroying */
+	rtnl_lock();	/* Prevent concurrent netdev(s) creation/destroying */
 
 	/* Remove all child netdev(s), using batch removing */
 	device_for_each_child(&wwandev->dev, &kill_list,
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
  2023-10-12  4:35 [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake Muhammad Muzammil
@ 2023-10-12  6:17 ` Muhammad Muzammil
  2023-10-12 17:03 ` Loic Poulain
  1 sibling, 0 replies; 6+ messages in thread
From: Muhammad Muzammil @ 2023-10-12  6:17 UTC (permalink / raw)
  To: horms, loic.poulain, ryazanov.s.a; +Cc: netdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

Hi Simon,

I created the v2 patch but I do not know why it was not recognized. I
have attached the patch file here.

On Thu, Oct 12, 2023 at 9:35 AM Muhammad Muzammil
<m.muzzammilashraf@gmail.com> wrote:
>
> resolved typing mistake from devce to device
>
> changes since v1:
>         - resolved another typing mistake from concurent to
>           concurrent
>
> Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
> ---
>  drivers/net/wwan/wwan_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 87df60916960..72e01e550a16 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
>
>  static const struct {
>         const char * const name;        /* Port type name */
> -       const char * const devsuf;      /* Port devce name suffix */
> +       const char * const devsuf;      /* Port device name suffix */
>  } wwan_port_types[WWAN_PORT_MAX + 1] = {
>         [WWAN_PORT_AT] = {
>                 .name = "AT",
> @@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
>          */
>         put_device(&wwandev->dev);
>
> -       rtnl_lock();    /* Prevent concurent netdev(s) creation/destroying */
> +       rtnl_lock();    /* Prevent concurrent netdev(s) creation/destroying */
>
>         /* Remove all child netdev(s), using batch removing */
>         device_for_each_child(&wwandev->dev, &kill_list,
> --
> 2.27.0
>

[-- Attachment #2: v2-0001-drivers-net-wwan-wwan_core.c-resolved-spelling-mi.patch --]
[-- Type: text/x-patch, Size: 1429 bytes --]

From 028f68cec88cd013f443388e94f79aa6a3556a4b Mon Sep 17 00:00:00 2001
From: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
Date: Thu, 12 Oct 2023 09:25:49 +0500
Subject: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake

resolved typing mistake from devce to device

changes since v1:
	- resolved another typing mistake from concurent to
	  concurrent

Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
---
 drivers/net/wwan/wwan_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 87df60916960..72e01e550a16 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
 
 static const struct {
 	const char * const name;	/* Port type name */
-	const char * const devsuf;	/* Port devce name suffix */
+	const char * const devsuf;	/* Port device name suffix */
 } wwan_port_types[WWAN_PORT_MAX + 1] = {
 	[WWAN_PORT_AT] = {
 		.name = "AT",
@@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
 	 */
 	put_device(&wwandev->dev);
 
-	rtnl_lock();	/* Prevent concurent netdev(s) creation/destroying */
+	rtnl_lock();	/* Prevent concurrent netdev(s) creation/destroying */
 
 	/* Remove all child netdev(s), using batch removing */
 	device_for_each_child(&wwandev->dev, &kill_list,
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
  2023-10-12  4:35 [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake Muhammad Muzammil
  2023-10-12  6:17 ` Muhammad Muzammil
@ 2023-10-12 17:03 ` Loic Poulain
  1 sibling, 0 replies; 6+ messages in thread
From: Loic Poulain @ 2023-10-12 17:03 UTC (permalink / raw)
  To: Muhammad Muzammil; +Cc: horms, ryazanov.s.a, netdev, linux-kernel

Hi Muhammad,

On Thu, 12 Oct 2023 at 06:35, Muhammad Muzammil
<m.muzzammilashraf@gmail.com> wrote:
>
> resolved typing mistake from devce to device
>
> changes since v1:

Change log should not be part of the commit message, simply drop the above line.

>         - resolved another typing mistake from concurent to
>           concurrent
>
> Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
> ---

You can put your change log here, e.g:
   v1: Fix 'concurrent' typo...

>  drivers/net/wwan/wwan_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 87df60916960..72e01e550a16 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
>
>  static const struct {
>         const char * const name;        /* Port type name */
> -       const char * const devsuf;      /* Port devce name suffix */
> +       const char * const devsuf;      /* Port device name suffix */
>  } wwan_port_types[WWAN_PORT_MAX + 1] = {
>         [WWAN_PORT_AT] = {
>                 .name = "AT",
> @@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
>          */
>         put_device(&wwandev->dev);
>
> -       rtnl_lock();    /* Prevent concurent netdev(s) creation/destroying */
> +       rtnl_lock();    /* Prevent concurrent netdev(s) creation/destroying */
>
>         /* Remove all child netdev(s), using batch removing */
>         device_for_each_child(&wwandev->dev, &kill_list,
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
@ 2023-10-13  4:23 Muhammad Muzammil
  2023-10-14  7:22 ` Simon Horman
  2023-10-17  0:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 6+ messages in thread
From: Muhammad Muzammil @ 2023-10-13  4:23 UTC (permalink / raw)
  To: horms, loic.poulain, ryazanov.s.a; +Cc: netdev, linux-kernel, Muhammad Muzammil

resolved typing mistake from devce to device

Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>

changes since v1:
	- resolved another typing mistake from concurent to
	  concurrent
---
 drivers/net/wwan/wwan_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 87df60916960..72e01e550a16 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
 
 static const struct {
 	const char * const name;	/* Port type name */
-	const char * const devsuf;	/* Port devce name suffix */
+	const char * const devsuf;	/* Port device name suffix */
 } wwan_port_types[WWAN_PORT_MAX + 1] = {
 	[WWAN_PORT_AT] = {
 		.name = "AT",
@@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
 	 */
 	put_device(&wwandev->dev);
 
-	rtnl_lock();	/* Prevent concurent netdev(s) creation/destroying */
+	rtnl_lock();	/* Prevent concurrent netdev(s) creation/destroying */
 
 	/* Remove all child netdev(s), using batch removing */
 	device_for_each_child(&wwandev->dev, &kill_list,
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
  2023-10-13  4:23 Muhammad Muzammil
@ 2023-10-14  7:22 ` Simon Horman
  2023-10-17  0:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-10-14  7:22 UTC (permalink / raw)
  To: Muhammad Muzammil; +Cc: loic.poulain, ryazanov.s.a, netdev, linux-kernel

On Fri, Oct 13, 2023 at 09:23:04AM +0500, Muhammad Muzammil wrote:
> resolved typing mistake from devce to device
> 
> Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
> 

As mentioned elsewhere, the "changes" text below is usually
placed below the scissors ("---").

I'm unsure if a v3 is warranted to address this.

> changes since v1:
> 	- resolved another typing mistake from concurent to
> 	  concurrent
> ---
>  drivers/net/wwan/wwan_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I confirm this corrects the two spelling errors flagged by codespell
in this file.

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
  2023-10-13  4:23 Muhammad Muzammil
  2023-10-14  7:22 ` Simon Horman
@ 2023-10-17  0:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-17  0:50 UTC (permalink / raw)
  To: Muhammad Muzammil; +Cc: horms, loic.poulain, ryazanov.s.a, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 13 Oct 2023 09:23:04 +0500 you wrote:
> resolved typing mistake from devce to device
> 
> Signed-off-by: Muhammad Muzammil <m.muzzammilashraf@gmail.com>
> 
> changes since v1:
> 	- resolved another typing mistake from concurent to
> 	  concurrent
> 
> [...]

Here is the summary with links:
  - [v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake
    https://git.kernel.org/netdev/net-next/c/97ddc25a368c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-10-17  0:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12  4:35 [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake Muhammad Muzammil
2023-10-12  6:17 ` Muhammad Muzammil
2023-10-12 17:03 ` Loic Poulain
  -- strict thread matches above, loose matches on Subject: below --
2023-10-13  4:23 Muhammad Muzammil
2023-10-14  7:22 ` Simon Horman
2023-10-17  0:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).