From: Cong Wang <xiyou.wangcong@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Daniel Borkmann <daniel@iogearbox.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Eyal Birger <eyal.birger@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v3 4/5] net/tc: introduce TC_ACT_REINJECT.
Date: Tue, 24 Jul 2018 13:38:29 -0700 [thread overview]
Message-ID: <CAM_iQpUHjoohcMgXd8y9GVn8hdFwMRGJeCJ5wSfphModf0qZ-A@mail.gmail.com> (raw)
In-Reply-To: <3c20787be0fd5d64728ffed46ae0a7dff10d7e05.1532437050.git.pabeni@redhat.com>
On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni <pabeni@redhat.com> wrote:
> +static inline void skb_tc_reinject(struct sk_buff *skb, struct tcf_result *res)
> +{
> + struct gnet_stats_queue *stats = res->qstats;
> + int ret;
> +
> + if (res->ingress)
> + ret = netif_receive_skb(skb);
> + else
> + ret = dev_queue_xmit(skb);
> + if (ret && stats)
> + qstats_overlimit_inc(res->qstats);
Why increasing overlimit? Overlimit is typically increased
by traffic shapers to indicate there is no bandwidth to send
out the packet.
I fail to understand why overlimit is increased in your case
here. I guess you want to increase 'drops' instead.
next prev parent reply other threads:[~2018-07-24 21:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 20:06 [PATCH net-next v3 0/5] TC: refactor act_mirred packets re-injection Paolo Abeni
2018-07-24 20:06 ` [PATCH net-next v3 1/5] tc/act: user space can't use TC_ACT_REDIRECT directly Paolo Abeni
2018-07-25 11:55 ` Jamal Hadi Salim
2018-07-25 11:56 ` Jiri Pirko
2018-07-25 12:54 ` Paolo Abeni
2018-07-25 13:03 ` Jiri Pirko
2018-07-25 15:48 ` Paolo Abeni
2018-07-25 16:29 ` Paolo Abeni
2018-07-25 16:29 ` Daniel Borkmann
2018-07-26 7:43 ` Jiri Pirko
2018-07-27 2:48 ` Daniel Borkmann
2018-07-24 20:06 ` [PATCH net-next v3 2/5] net/sched: user-space can't set unknown tcfa_action values Paolo Abeni
2018-07-25 12:26 ` Jiri Pirko
2018-07-24 20:06 ` [PATCH net-next v3 3/5] tc/act: remove unneeded RCU lock in action callback Paolo Abeni
2018-07-25 11:59 ` Jamal Hadi Salim
2018-07-25 18:24 ` Marcelo Ricardo Leitner
2018-07-25 12:32 ` Jiri Pirko
2018-07-24 20:06 ` [PATCH net-next v3 4/5] net/tc: introduce TC_ACT_REINJECT Paolo Abeni
2018-07-24 20:38 ` Cong Wang [this message]
2018-07-24 20:50 ` Cong Wang
2018-07-25 8:29 ` Paolo Abeni
2018-07-25 12:27 ` Jamal Hadi Salim
2018-07-25 14:24 ` Paolo Abeni
2018-07-25 15:26 ` Jamal Hadi Salim
2018-07-25 16:48 ` Cong Wang
2018-07-25 17:09 ` Marcelo Ricardo Leitner
2018-07-26 12:52 ` Jamal Hadi Salim
2018-07-26 23:25 ` Cong Wang
2018-07-25 12:16 ` Jamal Hadi Salim
2018-07-25 12:59 ` Jiri Pirko
2018-07-25 13:55 ` Paolo Abeni
2018-07-25 12:57 ` Jiri Pirko
2018-07-24 20:06 ` [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible Paolo Abeni
2018-07-24 21:15 ` Cong Wang
2018-07-25 10:14 ` Paolo Abeni
2018-07-25 13:30 ` Jiri Pirko
2018-07-25 11:50 ` Jamal Hadi Salim
2018-07-25 13:52 ` Jiri Pirko
2018-07-25 14:04 ` Paolo Abeni
2018-07-25 14:30 ` Jiri Pirko
2018-07-25 11:53 ` [PATCH net-next v3 0/5] TC: refactor act_mirred packets re-injection Jiri Pirko
2018-07-25 12:07 ` Paolo Abeni
2018-07-25 12:17 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpUHjoohcMgXd8y9GVn8hdFwMRGJeCJ5wSfphModf0qZ-A@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eyal.birger@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).