* [patch net] net: sched: fix p_filter_chain check in tcf_chain_flush
@ 2017-08-18 8:10 Jiri Pirko
2017-08-18 16:59 ` Cong Wang
2017-08-18 17:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2017-08-18 8:10 UTC (permalink / raw)
To: netdev; +Cc: davem, jhs, xiyou.wangcong, mlxsw
From: Jiri Pirko <jiri@mellanox.com>
The dereference before check is wrong and leads to an oops when
p_filter_chain is NULL. The check needs to be done on the pointer to
prevent NULL dereference.
Fixes: f93e1cdcf42c ("net/sched: fix filter flushing")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
net/sched/cls_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index ebeeb87..eef6b07 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -190,7 +190,7 @@ static void tcf_chain_flush(struct tcf_chain *chain)
{
struct tcf_proto *tp;
- if (*chain->p_filter_chain)
+ if (chain->p_filter_chain)
RCU_INIT_POINTER(*chain->p_filter_chain, NULL);
while ((tp = rtnl_dereference(chain->filter_chain)) != NULL) {
RCU_INIT_POINTER(chain->filter_chain, tp->next);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch net] net: sched: fix p_filter_chain check in tcf_chain_flush
2017-08-18 8:10 [patch net] net: sched: fix p_filter_chain check in tcf_chain_flush Jiri Pirko
@ 2017-08-18 16:59 ` Cong Wang
2017-08-18 17:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2017-08-18 16:59 UTC (permalink / raw)
To: Jiri Pirko
Cc: Linux Kernel Network Developers, David Miller, Jamal Hadi Salim,
mlxsw
On Fri, Aug 18, 2017 at 1:10 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> The dereference before check is wrong and leads to an oops when
> p_filter_chain is NULL. The check needs to be done on the pointer to
> prevent NULL dereference.
>
> Fixes: f93e1cdcf42c ("net/sched: fix filter flushing")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch net] net: sched: fix p_filter_chain check in tcf_chain_flush
2017-08-18 8:10 [patch net] net: sched: fix p_filter_chain check in tcf_chain_flush Jiri Pirko
2017-08-18 16:59 ` Cong Wang
@ 2017-08-18 17:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-18 17:19 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs, xiyou.wangcong, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 18 Aug 2017 10:10:43 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> The dereference before check is wrong and leads to an oops when
> p_filter_chain is NULL. The check needs to be done on the pointer to
> prevent NULL dereference.
>
> Fixes: f93e1cdcf42c ("net/sched: fix filter flushing")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied, thanks Jiri.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-18 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-18 8:10 [patch net] net: sched: fix p_filter_chain check in tcf_chain_flush Jiri Pirko
2017-08-18 16:59 ` Cong Wang
2017-08-18 17:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).