From: Cong Wang <xiyou.wangcong@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Dave Täht" <dave.taht@gmail.com>,
netdev <netdev@vger.kernel.org>, moeller0 <moeller0@gmx.de>
Subject: Re: [PATCH net-next] fq_codel: add memory limitation per queue
Date: Mon, 9 May 2016 21:34:50 -0700 [thread overview]
Message-ID: <CAM_iQpURNs3vVVN1cceRLh2ptvsMno3bPubc9wwfQvcWe8je8g@mail.gmail.com> (raw)
In-Reply-To: <1462804008.23934.30.camel@edumazet-glaptop3.roam.corp.google.com>
On Mon, May 9, 2016 at 7:26 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Sun, 2016-05-08 at 22:07 -0700, Cong Wang wrote:
>> On Sun, May 8, 2016 at 9:31 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> > On Sun, 2016-05-08 at 21:14 -0700, Cong Wang wrote:
>> >
>> >> So when the packet is dropped due to memory over limit, should
>> >> we return failure for this case? Or I miss anything?
>> >
>> > Same behavior than before.
>> >
>> > If we dropped some packets of this flow, we return NET_XMIT_CN
>>
>> I think for the limited memory case, the upper layer is supposed
>> to stop sending more packets when hitting the limit.
>
> They doe. NET_XMIT_CN for example aborts IP fragmentation.
>
> TCP flows will also instantly react.
But not for the NET_XMIT_SUCCESS case:
return ret == idx ? NET_XMIT_CN : NET_XMIT_SUCCESS;
next prev parent reply other threads:[~2016-05-10 4:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAA93jw6QLyx9EaS+ntB0D3duoysu_Z-UYyQfHnRa=pfqPDfWOw@mail.gmail.com>
[not found] ` <1462125592.5535.194.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <865DA393-262D-40B6-A9D3-1B978CD5F6C6@gmail.com>
[not found] ` <1462128385.5535.200.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <C5D365DA-18EE-446E-9D25-41F48B1C583E@gmail.com>
[not found] ` <1462136140.5535.219.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <CACiydbKUu11=zWitkDha0ddgk1-G_Z4-e1+=9ky776VktF5HHg@mail.gmail.com>
[not found] ` <1462201620.5535.250.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <CACiydbKeKUENncrc-NmYRcku-DGVeGqqzYMqsCqKdxPsR7yUOQ@mail.gmail.com>
[not found] ` <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <CACiydbL26Jj3EcEL4EmqaH=1Dm-Q0dpVwoWxqUSZ7ry10bRgeg@mail.gmail.com>
[not found] ` <1462464776.13075.18.camel@edumazet-glaptop3.roam.corp.google.com>
[not found] ` <CACiydbJYrFRMJvSHM6tJYWR8vmgV3xxnSUQsb-h5WcnLW=KXoQ@mail.gmail.com>
[not found] ` <1462476207.13075.20.camel@edumazet-glaptop3.roam.corp.google.com>
2016-05-06 9:42 ` OpenWRT wrong adjustment of fq_codel defaults (Was: fq_codel_drop vs a udp flood) Jesper Dangaard Brouer
2016-05-06 12:47 ` Jesper Dangaard Brouer
2016-05-06 18:43 ` Roman Yeryomin
2016-05-06 18:56 ` Roman Yeryomin
2016-05-06 19:43 ` Dave Taht
2016-05-15 22:34 ` Roman Yeryomin
2016-05-15 23:07 ` Eric Dumazet
2016-05-15 23:27 ` Roman Yeryomin
2016-05-16 8:12 ` [Make-wifi-fast] " David Lang
2016-05-16 8:26 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Roman Yeryomin
2016-05-16 8:46 ` [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: " David Lang
2016-05-16 10:34 ` [OpenWrt-Devel] " Sebastian Moeller
2016-05-16 8:14 ` Roman Yeryomin
2016-05-16 14:23 ` [Make-wifi-fast] " Eric Dumazet
2016-05-16 16:04 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Dave Taht
2016-05-16 19:46 ` OpenWRT wrong adjustment of fq_codel defaults (Was: " Roman Yeryomin
2016-05-07 9:57 ` OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] " Kevin Darbyshire-Bryant
2016-05-15 22:47 ` Roman Yeryomin
[not found] ` <CAA93jw4XZ1+LLX1z6wQ6DHsp4vFCS5zmMz-uku_8SBNG_KuUxA@mail.gmail.com>
[not found] ` <542135C7-D7CC-4E33-B35B-C2AD259FA5AB@gmx.de>
[not found] ` <20160506133323.0b190f47@redhat.com>
[not found] ` <D29AB9B2-D514-4D14-9A16-CFB9ECD05B17@gmx.de>
[not found] ` <1462541156.13075.34.camel@edumazet-glaptop3.roam.corp.google.com>
2016-05-06 15:55 ` [PATCH net-next] fq_codel: add memory limitation per queue Eric Dumazet
2016-05-09 3:49 ` David Miller
2016-05-09 4:14 ` Cong Wang
2016-05-09 4:31 ` Eric Dumazet
2016-05-09 5:07 ` Cong Wang
2016-05-09 14:26 ` Eric Dumazet
2016-05-10 4:34 ` Cong Wang [this message]
2016-05-10 4:45 ` Eric Dumazet
2016-05-10 4:57 ` Cong Wang
2016-05-10 5:10 ` Eric Dumazet
2016-05-16 1:16 ` [PATCH net-next] fq_codel: fix memory limitation drift Eric Dumazet
2016-05-17 1:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpURNs3vVVN1cceRLh2ptvsMno3bPubc9wwfQvcWe8je8g@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=brouer@redhat.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=moeller0@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).