From: Cong Wang <xiyou.wangcong@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [Patch net-next 2/2] netns: avoid disabling irq for netns id
Date: Fri, 2 Sep 2016 09:39:32 -0700 [thread overview]
Message-ID: <CAM_iQpUSoPHDCG5yehmgKgO99Qr_rtR0gZvEeOr3cO-o_LfuXQ@mail.gmail.com> (raw)
In-Reply-To: <7de98923-0cfb-5937-d32b-bdaee7ec10dc@6wind.com>
On Fri, Sep 2, 2016 at 1:12 AM, Nicolas Dichtel
<nicolas.dichtel@6wind.com> wrote:
> Le 02/09/2016 à 06:53, Cong Wang a écrit :
>> We never read or change netns id in hardirq context,
>> the only place we read netns id in softirq context
>> is in vxlan_xmit(). So, it should be enough to just
>> disable BH.
>
> Are you sure? Did you audit all part of the code?
I did audit all the callers, and I didn't find any of them in IRQ context.
> peernet2id() is called from netlink core system (do_one_broadcast()). Are you
> sure that no driver call this function from an hard irq context?
I audit all callers of netlink_broadcast(), and I don't see any of
them in hardirq context.
>
> I think that NETLINK_LISTEN_ALL_NSID is largely untested, so it will be hard to
> detect a bug introduced in this feature.
This patch passed my netns stress tests, I have LOCKDEP enabled,
and I don't get any warning or crash etc.
next prev parent reply other threads:[~2016-09-02 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 4:53 [Patch net-next 0/2] net: some minor optimization for netns id Cong Wang
2016-09-02 4:53 ` [Patch net-next 1/2] vxlan: call peernet2id() in fdb notification Cong Wang
2016-09-02 8:59 ` Nicolas Dichtel
2016-09-02 4:53 ` [Patch net-next 2/2] netns: avoid disabling irq for netns id Cong Wang
2016-09-02 8:12 ` Nicolas Dichtel
2016-09-02 16:39 ` Cong Wang [this message]
2016-09-02 17:24 ` Cong Wang
2016-09-04 20:23 ` Nicolas Dichtel
2016-10-19 15:21 ` Elad Raz
2016-10-19 20:07 ` Cong Wang
2017-01-31 6:47 ` Elluru, Krishna Mohan
2017-01-31 6:53 ` Cong Wang
2017-01-31 7:10 ` Elluru, Krishna Mohan
2017-01-31 8:24 ` Nicolas Dichtel
2016-09-04 18:40 ` [Patch net-next 0/2] net: some minor optimization " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpUSoPHDCG5yehmgKgO99Qr_rtR0gZvEeOr3cO-o_LfuXQ@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).