From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc
Date: Tue, 1 May 2018 15:31:49 -0700
Message-ID: <CAM_iQpUa8snecbrdKrtj6VPYzVrbf__Z-hvTePXND0nMroPrWQ@mail.gmail.com>
References: <20180429213439.7389-1-toke@toke.dk> <CAM_iQpWVrhoo+PjguBLYqwyGyX98Cv3-M=G+CbHrwBom13fwZQ@mail.gmail.com>
 <CAA93jw6F+c-QRXe+MA2QmRkwiKEBqFgOFKTvWGfO7FvCQ5tFvw@mail.gmail.com>
 <dff5ba09-1b81-7cd8-4be3-e7a419797d8e@gmail.com> <878t932ont.fsf@toke.dk> <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Dave Taht <dave.taht@gmail.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Cake List <cake@lists.bufferbloat.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f174.google.com ([209.85.192.174]:37748 "EHLO
        mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750743AbeEAWcK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 1 May 2018 18:32:10 -0400
Received: by mail-pf0-f174.google.com with SMTP id e9so6077396pfi.4
        for <netdev@vger.kernel.org>; Tue, 01 May 2018 15:32:09 -0700 (PDT)
In-Reply-To: <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, May 1, 2018 at 12:12 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> I guess that nobody really wants to really review Cake if
> it is a file with 2700 lines of code and hundreds of variables/tunables.
>
> Sure, we have big files in networking land, as a result of thousands of changes.
>
> If you split it, then maybe the work can be split among reviewers as a result.
>

+1

At *least* split it into CAKE without ack-filter and ack-filter implementation.