Re: [PATCH RFC net-next 0/2] net:sched: Introduce tc flower2 classifier based on PANDA parser in kernel

[Cong Wang <xiyou.wangcong@gmail.com>]

On Thu, Sep 16, 2021 at 1:02 PM Felipe Magno de Almeida
<felipe@sipanda.io> wrote:
>
> The PANDA parser, introduced in [1], addresses most of these problems
> and introduces a developer friendly highly maintainable approach to
> adding extensions to the parser. This RFC patch takes a known consumer
> of flow dissector - tc flower - and  shows how it could make use of
> the PANDA Parser by mostly cutnpaste of the flower code. The new
> classifier is called "flower2". The control semantics of flower are
> maintained but the flow dissector parser is replaced with a PANDA
> Parser. The iproute2 patch is sent separately - but you'll notice
> other than replacing the user space tc commands with "flower2"  the
> syntax is exactly the same. To illustrate the flexibility of PANDA we
> show a simple use case of the issues described in [2] when flower
> consumes PANDA. The PANDA Parser is part of the PANDA programming
> model for network datapaths, this is described in
> https://github.com/panda-net/panda.

My only concern is that is there any way to reuse flower code instead
of duplicating most of them? Especially when you specifically mentioned
flower2 has the same user-space syntax as flower, this makes code
reusing more reasonable.

Thanks.