From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net-next] net: remove redundant input checks in
 SIOCSIFTXQLEN case of dev_ifsioc
Date: Thu, 19 Jul 2018 10:21:06 -0700
Message-ID: <CAM_iQpV-pcr5OaTN1N-iYQt+KiTKy6U590Z_1e4vv3vebUsMdA@mail.gmail.com>
References: <1532011832-6952-1-git-send-email-tariqt@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: David Miller <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        eranbe@mellanox.com
To: Tariq Toukan <tariqt@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f196.google.com ([209.85.215.196]:33299 "EHLO
        mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731979AbeGSSDg (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Jul 2018 14:03:36 -0400
Received: by mail-pg1-f196.google.com with SMTP id r5-v6so4353466pgv.0
        for <netdev@vger.kernel.org>; Thu, 19 Jul 2018 10:19:29 -0700 (PDT)
In-Reply-To: <1532011832-6952-1-git-send-email-tariqt@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan <tariqt@mellanox.com> wrote:
> --- a/net/core/dev_ioctl.c
> +++ b/net/core/dev_ioctl.c
> @@ -282,14 +282,7 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd)
>                 return dev_mc_del_global(dev, ifr->ifr_hwaddr.sa_data);
>
>         case SIOCSIFTXQLEN:
> -               if (ifr->ifr_qlen < 0)
> -                       return -EINVAL;

Are you sure we can remove this if check too?

The other one is safe to remove.