From: Cong Wang <xiyou.wangcong@gmail.com>
To: wenxu <wenxu@ucloud.cn>
Cc: Jakub Kicinski <kuba@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@nvidia.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 0/3] net/sched: fix over mtu packet of defrag in
Date: Fri, 20 Nov 2020 11:28:49 -0800 [thread overview]
Message-ID: <CAM_iQpV1Lyw4yNUEof1kERA1vWLediDGAsfHf_UVxuS2HMNHYg@mail.gmail.com> (raw)
In-Reply-To: <1605829116-10056-1-git-send-email-wenxu@ucloud.cn>
On Thu, Nov 19, 2020 at 3:39 PM <wenxu@ucloud.cn> wrote:
>
> From: wenxu <wenxu@ucloud.cn>
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redirect
> mirred to a device which maybe lead the reassembly big packet over the mtu
> of target device.
>
> The first patch fix miss init the qdisc_skb_cb->mru
> The send one refactor the hanle of xmit in act_mirred and prepare for the
> third one
> The last one add implict packet fragment support to fix the over mtu for
> defrag in act_ct.
Overall it looks much better to me now, so:
Acked-by: Cong Wang <cong.wang@bytedance.com>
Thanks!
next prev parent reply other threads:[~2020-11-20 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 23:38 [PATCH v3 net-next 0/3] net/sched: fix over mtu packet of defrag in wenxu
2020-11-19 23:38 ` [PATCH v3 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb wenxu
2020-11-19 23:38 ` [PATCH v3 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit wenxu
2020-11-19 23:38 ` [PATCH v3 net-next 3/3] net/sched: sch_frag: add generic packet fragment support wenxu
2020-11-24 19:24 ` Jakub Kicinski
2020-11-24 23:10 ` wenxu
2020-11-25 0:02 ` Jakub Kicinski
2020-11-20 19:28 ` Cong Wang [this message]
2020-11-21 14:39 ` [PATCH v3 net-next 0/3] net/sched: fix over mtu packet of defrag in Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpV1Lyw4yNUEof1kERA1vWLediDGAsfHf_UVxuS2HMNHYg@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@nvidia.com \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).