From: Cong Wang <xiyou.wangcong@gmail.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
Eric Dumazet <edumazet@google.com>, Wei Wang <weiwan@google.com>,
"Cong Wang ." <cong.wang@bytedance.com>,
Taehee Yoo <ap420073@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxarm@openeuler.org, Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
kpsingh@kernel.org, bpf <bpf@vger.kernel.org>,
Jonas Bonn <jonas.bonn@netrounds.com>,
Paolo Abeni <pabeni@redhat.com>,
Michael Zhivich <mzhivich@akamai.com>,
Josh Hunt <johunt@akamai.com>, Jike Song <albcamus@gmail.com>,
Kehuan Feng <kehuan.feng@gmail.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [Linuxarm] [PATCH net] net: sched: fix packet stuck problem for lockless qdisc
Date: Fri, 19 Mar 2021 12:45:30 -0700 [thread overview]
Message-ID: <CAM_iQpV4HX5L1b8ofUig-bi3r_MDdsjThqaxfoRCd=02XZBprQ@mail.gmail.com> (raw)
In-Reply-To: <e5c2d82c-0158-3997-80b6-4aab56c61367@huawei.com>
On Fri, Mar 19, 2021 at 2:25 AM Yunsheng Lin <linyunsheng@huawei.com> wrote:
> I had done some performance test to see if there is value to
> fix the packet stuck problem and support lockless qdisc bypass,
> here is some result using pktgen in 'queue_xmit' mode on a dummy
> device as Paolo Abeni had done in [1], and using pfifo_fast qdisc:
>
> threads vanilla locked-qdisc vanilla+this_patch
> 1 2.6Mpps 2.9Mpps 2.5Mpps
> 2 3.9Mpps 4.8Mpps 3.6Mpps
> 4 5.6Mpps 3.0Mpps 4.7Mpps
> 8 2.7Mpps 1.6Mpps 2.8Mpps
> 16 2.2Mpps 1.3Mpps 2.3Mpps
>
> locked-qdisc: test by removing the "TCQ_F_NOLOCK | TCQ_F_CPUSTATS".
I read this as this patch introduces somehow a performance
regression for -net, as the lockless bypass patch you submitted is
for -net-next.
Thanks.
next prev parent reply other threads:[~2021-03-19 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 6:53 [PATCH net] net: sched: fix packet stuck problem for lockless qdisc Yunsheng Lin
2021-03-19 9:25 ` [Linuxarm] " Yunsheng Lin
2021-03-19 19:45 ` Cong Wang [this message]
2021-03-22 1:37 ` Yunsheng Lin
2021-03-19 19:40 ` Cong Wang
2021-03-22 1:31 ` Yunsheng Lin
2021-03-22 9:09 ` [RFC v3] net: sched: implement TCQ_F_CAN_BYPASS " Yunsheng Lin
2021-03-22 20:00 ` Vladimir Oltean
2021-03-23 11:39 ` Vladimir Oltean
2021-03-23 6:37 ` Ahmad Fatoum
2021-03-23 11:34 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpV4HX5L1b8ofUig-bi3r_MDdsjThqaxfoRCd=02XZBprQ@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=albcamus@gmail.com \
--cc=andrii@kernel.org \
--cc=andriin@fb.com \
--cc=ap420073@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=johunt@akamai.com \
--cc=jonas.bonn@netrounds.com \
--cc=kafai@fb.com \
--cc=kehuan.feng@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=linyunsheng@huawei.com \
--cc=mkl@pengutronix.de \
--cc=mzhivich@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=songliubraving@fb.com \
--cc=weiwan@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).