From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [patch net-next v10 02/13] net: sched: introduce shared filter blocks infrastructure Date: Tue, 16 Jan 2018 16:03:15 -0800 Message-ID: References: <20180116153316.4751-1-jiri@resnulli.us> <20180116153316.4751-3-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Linux Kernel Network Developers , David Miller , Jamal Hadi Salim , mlxsw@mellanox.com, andrew@lunn.ch, Vivien Didelot , Florian Fainelli , michael.chan@broadcom.com, ganeshgr@chelsio.com, Saeed Mahameed , matanb@mellanox.com, leonro@mellanox.com, Ido Schimmel , Jakub Kicinski , Simon Horman , Pieter Jansen van Vuuren , john.hurley@netronome.com, Alexander Duyck , Or Gerlitz , John Fastabend , Daniel Borkmann Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:38272 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbeAQADh (ORCPT ); Tue, 16 Jan 2018 19:03:37 -0500 Received: by mail-pf0-f196.google.com with SMTP id k19so10559234pfj.5 for ; Tue, 16 Jan 2018 16:03:36 -0800 (PST) In-Reply-To: <20180116153316.4751-3-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 16, 2018 at 7:33 AM, Jiri Pirko wrote: > static int __init tc_filter_init(void) > { > + int err; > + > tc_filter_wq = alloc_ordered_workqueue("tc_filter_workqueue", 0); > if (!tc_filter_wq) > return -ENOMEM; > > + err = register_pernet_subsys(&tcf_net_ops); > + if (err) > + return err; Need to destroy the above workqueue on error.