From: Cong Wang <xiyou.wangcong@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: "Linux Kernel Network Developers" <netdev@vger.kernel.org>,
"Стас Ничипорович" <stasn77@gmail.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>
Subject: Re: [Patch net] act_police: fix a crash during removal
Date: Sun, 5 Jun 2016 22:41:29 -0700 [thread overview]
Message-ID: <CAM_iQpV9e7RcKpw7EE-36uq1NMjVYrWRXSSMr7NNHrQ=gw3tkw@mail.gmail.com> (raw)
In-Reply-To: <20160603.192841.407832783155363455.davem@davemloft.net>
On Fri, Jun 3, 2016 at 4:28 PM, David Miller <davem@davemloft.net> wrote:
> From: Cong Wang <xiyou.wangcong@gmail.com>
> Date: Wed, 1 Jun 2016 16:15:20 -0700
>
>> The police action is using its own code to initialize tcf hash
>> info, which makes us to forgot to initialize a->hinfo correctly.
>> Fix this by calling the helper function tcf_hash_create() directly.
>>
>> This patch fixed the following crash:
> ...
>> Fixes: ddf97ccdd7cb ("net_sched: add network namespace support for tc actions")
>> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>
> This adds a new warning, please resubmit with this fixed.
>
> net/sched/act_police.c: In function ‘tcf_act_police_locate’:
> net/sched/act_police.c:247:3: warning: ‘police’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Oh, sure, my compiler didn't catch this.
I will send v2 tomorrow.
next prev parent reply other threads:[~2016-06-06 5:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 23:15 [Patch net] sch_hfsc: always keep backlog updated Cong Wang
2016-06-01 23:15 ` [Patch net] sch_prio: update backlog as well Cong Wang
2016-06-03 23:26 ` David Miller
2016-06-01 23:15 ` [Patch net] sch_drr: " Cong Wang
2016-06-03 23:25 ` David Miller
2016-06-01 23:15 ` [Patch net] sch_red: " Cong Wang
2016-06-03 23:25 ` David Miller
2016-06-01 23:15 ` [Patch net] sch_tbf: " Cong Wang
2016-06-03 23:26 ` David Miller
2016-06-01 23:15 ` [Patch net] act_police: fix a crash during removal Cong Wang
2016-06-03 23:28 ` David Miller
2016-06-06 5:41 ` Cong Wang [this message]
2016-06-03 23:26 ` [Patch net] sch_hfsc: always keep backlog updated David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpV9e7RcKpw7EE-36uq1NMjVYrWRXSSMr7NNHrQ=gw3tkw@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stasn77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).