From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net] net/sched: act_police: add missing spinlock initialization
Date: Wed, 21 Nov 2018 10:02:53 -0800
Message-ID: <CAM_iQpVE+sDEHxoo2r4AM3Z7RFE3OV76MWh+21S569Prg0VGHA@mail.gmail.com>
References: <070f7a50d9fe76cb459b28d03fa322ce3dd59cb1.1542819002.git.dcaratti@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Eric Dumazet <edumazet@google.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Jiri Pirko <jiri@resnulli.us>,
        David Miller <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Ivan Vecera <ivecera@redhat.com>
To: Davide Caratti <dcaratti@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f194.google.com ([209.85.214.194]:44505 "EHLO
        mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729904AbeKVEi2 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 21 Nov 2018 23:38:28 -0500
Received: by mail-pl1-f194.google.com with SMTP id s5-v6so6562572plq.11
        for <netdev@vger.kernel.org>; Wed, 21 Nov 2018 10:03:05 -0800 (PST)
In-Reply-To: <070f7a50d9fe76cb459b28d03fa322ce3dd59cb1.1542819002.git.dcaratti@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 21, 2018 at 9:24 AM Davide Caratti <dcaratti@redhat.com> wrote:
>
> commit f2cbd4852820 ("net/sched: act_police: fix race condition on state
> variables") introduces a new spinlock, but forgets its initialization.
> Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police'
> action is newly created, to avoid the following lockdep splat:

Acked-by: Cong Wang <xiyou.wangcong@gmail.com>