From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Andrey Wagin <avagin@gmail.com>, Kaiwen Xu <kaiwen.xu@hulu.com>
Subject: Re: [Patch net] tcp: reset sk_rx_dst in tcp_disconnect()
Date: Wed, 5 Jul 2017 09:40:36 -0700 [thread overview]
Message-ID: <CAM_iQpVGd3f=rFU5hg2+5um0eE5EP3tNUDxfy631Pxp1O9c0bw@mail.gmail.com> (raw)
In-Reply-To: <CAAvyFNitoxhPpivWaY+qgW+ssVxvt-3O+4eBfYCN81a0Dn7JZg@mail.gmail.com>
On Tue, Jul 4, 2017 at 11:54 PM, Jamie Bainbridge
<jamie.bainbridge@gmail.com> wrote:
> On 25 June 2017 at 16:50, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> We have to reset the sk->sk_rx_dst when we disconnect a TCP
>> connection, because otherwise when we re-connect it this
>> dst reference is simply overridden in tcp_finish_connect().
>>
>> This fixes a dst leak which leads to a loopback dev refcnt
>> leak. It is a long-standing bug, Kevin reported a very similar
>> (if not same) bug before. Thanks to Andrei for providing such
>> a reliable reproducer which greatly narrows down the problem.
>>
>> Fixes: 41063e9dd119 ("ipv4: Early TCP socket demux.")
>> Reported-by: Andrei Vagin <avagin@gmail.com>
>> Reported-by: Kevin Xu <kaiwen.xu@hulu.com>
>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>
> Are you able to supply the reproducer for this?
>
> I did search for a previous thread about it but could not find.
Here it is:
http://marc.info/?l=linux-kernel&m=149825461307610&w=2
prev parent reply other threads:[~2017-07-05 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-25 6:50 [Patch net] tcp: reset sk_rx_dst in tcp_disconnect() Cong Wang
2017-06-25 16:23 ` David Miller
2017-07-05 6:54 ` Jamie Bainbridge
2017-07-05 16:40 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpVGd3f=rFU5hg2+5um0eE5EP3tNUDxfy631Pxp1O9c0bw@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=avagin@gmail.com \
--cc=jamie.bainbridge@gmail.com \
--cc=kaiwen.xu@hulu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).