From: Cong Wang <xiyou.wangcong@gmail.com>
To: "Fredrik Markström" <fredrik.markstrom@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org,
Alexei Starovoitov <ast@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 0/2] net: Set maximum receive packet size on veth interfaces
Date: Thu, 11 May 2017 20:27:10 -0700 [thread overview]
Message-ID: <CAM_iQpVKJp5Dg_x-ymJa-wpLbbgUpn2cQv+--eXRwr2Eh23Vgw@mail.gmail.com> (raw)
In-Reply-To: <CAKdL+dQh9ZEWZKHam0Z3iaVpxgZY0mziT3ZWN1OcuS55zUjEXg@mail.gmail.com>
On Tue, May 9, 2017 at 5:42 PM, Fredrik Markström
<fredrik.markstrom@gmail.com> wrote:
>
> Maybe I was unclear, the veth implementation drops all packers larger then the
> configured MTU (on the receiving interface).
> Most ethernet drivers accepts packets up to the ethernet MTU no matter the
> configured MTU. As far as I can tell from the RFC:s that is ok.
This is because IP layer does the fragmentation for you. But some drivers,
for example tg3, drop packet larger than its dev->mtu very early too.
>
> A simpler solution would be to only drop packets larger then ethernet MTU (like
> most network drivers), but I guess that will break existing stuff
> already out there.
I wonder why did we introduce that mtu check for veth when IP layer
could either fragment or reject with ICMP?
prev parent reply other threads:[~2017-05-12 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 12:44 [PATCH 0/2] net: Set maximum receive packet size on veth interfaces Fredrik Markstrom
2017-05-09 12:44 ` [PATCH 1/2] net: Added mtu parameter to dev_forward_skb calls Fredrik Markstrom
2017-05-10 11:47 ` kbuild test robot
2017-05-09 12:44 ` [PATCH 2/2] veth: Added attribute to set maximum receive size on veth interfaces Fredrik Markstrom
2017-05-09 12:44 ` Support for VETH_MRU in libnl Fredrik Markstrom
2017-05-09 15:49 ` [PATCH 0/2] net: Set maximum receive packet size on veth interfaces Stephen Hemminger
2017-05-09 17:48 ` David Miller
2017-05-10 0:38 ` Fredrik Markström
2017-05-10 0:42 ` Fredrik Markström
2017-05-12 3:27 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpVKJp5Dg_x-ymJa-wpLbbgUpn2cQv+--eXRwr2Eh23Vgw@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=ast@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fredrik.markstrom@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).