From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net] net/sched: act_tunnel_key: fix memory leak in case of
 action replace
Date: Fri, 11 Jan 2019 14:25:58 -0800
Message-ID: <CAM_iQpVM43ufRm1eV1=kpGfYHPPRCX_rJV8CsvsRcM+UWyaSuQ@mail.gmail.com>
References: <61be610db89454f4ad2a02e18e213931dda26963.1547147773.git.dcaratti@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Amir Vadai <amir@vadai.me>
To: Davide Caratti <dcaratti@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f194.google.com ([209.85.215.194]:42338 "EHLO
        mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725767AbfAKW0K (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 11 Jan 2019 17:26:10 -0500
Received: by mail-pg1-f194.google.com with SMTP id d72so6869476pga.9
        for <netdev@vger.kernel.org>; Fri, 11 Jan 2019 14:26:10 -0800 (PST)
In-Reply-To: <61be610db89454f4ad2a02e18e213931dda26963.1547147773.git.dcaratti@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jan 10, 2019 at 11:21 AM Davide Caratti <dcaratti@redhat.com> wrote:
> when the tunnel_key action is replaced, the kernel forgets to release the
> dst metadata: ensure they are released by tunnel_key_init(), the same way
> it's done in tunnel_key_release().
>
> Fixes: d0f6dd8a914f4 ("net/sched: Introduce act_tunnel_key")
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Acked-by: Cong Wang <xiyou.wangcong@gmail.com>