From: Cong Wang <xiyou.wangcong@gmail.com>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Or Gerlitz <gerlitz.or@gmail.com>,
Tom Herbert <tom@herbertland.com>,
Linux Netdev List <netdev@vger.kernel.org>,
Shani Michaeli <shanim@mellanox.com>,
Tariq Toukan <tariqt@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>,
Carol L Soto <clsoto@us.ibm.com>
Subject: Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum
Date: Thu, 30 Jun 2016 10:08:28 -0700 [thread overview]
Message-ID: <CAM_iQpVijBedKTnU3A4Oa5tWn_qHDEDmJ4aHXH-7bB4xmU_2DA@mail.gmail.com> (raw)
In-Reply-To: <ca13266f-4cd9-3ac1-9092-9142475cbce9@gmail.com>
On Wed, Jun 29, 2016 at 7:23 AM, Tariq Toukan <ttoukan.linux@gmail.com> wrote:
> Hi Cong,
>
>> See below. Does commit f8c6455bb04b944edb69e rely on any firmware
>> change to get an expected checksum?
>>
>> $ lspci -nn | grep -i mellanox
>> 82:00.0 Ethernet controller [0200]: Mellanox Technologies MT27500
>> Family [ConnectX-3] [15b3:1003]
>>
>> $ ethtool -i eth0
>> driver: mlx4_en
>> version: 2.2-1 (Feb 2014)
>> firmware-version: 2.33.5220
>> bus-info: 0000:82:00.0
>
> I used same HW and FW, but was not able to reproduce.
> I have kernel HEAD of net-next: 8a79813c1401 net: ethernet: dwc_eth_qos: use
> phy_ethtool_{get|set}_link_ksettings
>
> I ran regular ping, and ping6. Checksum complete counter increases, but no
> warnings in dmesg.
Thanks for testing it! This helps me a lot to identify the real bug.
Actually the bug is in mirred action instead of mlx4 driver, I have
a patch and just confirmed it fixes the bug. I will send it out in a
few minutes.
Again, thanks a lot for your help!
prev parent reply other threads:[~2016-06-30 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 18:22 [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum Cong Wang
2016-06-27 21:08 ` Or Gerlitz
2016-06-27 21:44 ` Cong Wang
2016-06-27 21:47 ` Tom Herbert
2016-06-27 21:49 ` Cong Wang
2016-06-27 22:04 ` Tom Herbert
2016-06-27 22:53 ` Cong Wang
2016-06-27 23:16 ` Tom Herbert
2016-06-28 14:30 ` Or Gerlitz
2016-06-28 16:52 ` Cong Wang
2016-06-29 14:23 ` Tariq Toukan
2016-06-29 14:33 ` Or Gerlitz
2016-06-30 17:08 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpVijBedKTnU3A4Oa5tWn_qHDEDmJ4aHXH-7bB4xmU_2DA@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=clsoto@us.ibm.com \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shanim@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=tom@herbertland.com \
--cc=ttoukan.linux@gmail.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).