From: Cong Wang <xiyou.wangcong@gmail.com>
To: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Cc: Sowmini Varadhan <sowmini.varadhan@oracle.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
rds-devel@oss.oracle.com
Subject: Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE
Date: Mon, 10 Sep 2018 17:45:04 -0700 [thread overview]
Message-ID: <CAM_iQpVn4pKCLM6O2251t-PFeUGNW45yY0Bn4XC4zXqL2C=Hgw@mail.gmail.com> (raw)
In-Reply-To: <17b2b2b8-12ce-076e-a961-2a8bee1d021f@oracle.com>
On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar
<santosh.shilimkar@oracle.com> wrote:
> Would you mind posting an updated patch please with call_rcu and
> above extended RCU grace period with rcu_read_lock. Thanks !!
If you prefer to fix _two_ problems in one patch, sure.
For the record, the bug this patch fixes is NOT same with the one
in rds_find_bound(), because there is no rds_find_bound() in
the backtrace. If you want to see the full backtrace, here it is:
https://marc.info/?l=linux-netdev&m=153644444808962&w=2
This is why I believe they are two problems.
Whether fixing two problems in one patch or two patches is
merely a preference, I leave it up to you.
next prev parent reply other threads:[~2018-09-11 5:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 22:24 [Patch net] rds: mark bound socket with SOCK_RCU_FREE Cong Wang
2018-09-10 22:34 ` Sowmini Varadhan
2018-09-10 22:43 ` Santosh Shilimkar
2018-09-10 23:30 ` Sowmini Varadhan
2018-09-10 23:51 ` Cong Wang
2018-09-11 0:04 ` Sowmini Varadhan
2018-09-11 0:16 ` Cong Wang
2018-09-11 0:24 ` Sowmini Varadhan
2018-09-11 0:39 ` Cong Wang
2018-09-11 0:26 ` Santosh Shilimkar
2018-09-11 0:45 ` Cong Wang [this message]
2018-09-11 0:56 ` Santosh Shilimkar
2018-09-11 0:59 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpVn4pKCLM6O2251t-PFeUGNW45yY0Bn4XC4zXqL2C=Hgw@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).