netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	mlxsw@mellanox.com
Subject: Re: [patch net-next] net: sched: atm: destroy main filter chain
Date: Fri, 24 Mar 2017 10:46:55 -0700	[thread overview]
Message-ID: <CAM_iQpVu=SCDZ7YdZDa3J9bugOsDb1Hzz=GnAS3r=-gAXik6gw@mail.gmail.com> (raw)
In-Reply-To: <1490362789-7293-1-git-send-email-jiri@resnulli.us>

On Fri, Mar 24, 2017 at 6:39 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> In atm_tc_destroy, the flow qdisc filter chains are destroyed. However
> the main chain is not. So fix this memory and reference leak.

Are you sure? 'link' is on the 'flows' already according
to this comment:

struct atm_qdisc_data {
        struct atm_flow_data    link;           /* unclassified skbs go here */
        struct list_head        flows;          /* NB: "link" is also on this
                                                   list */
        struct tasklet_struct   task;           /* dequeue tasklet */
};

  reply	other threads:[~2017-03-24 17:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 13:39 [patch net-next] net: sched: atm: destroy main filter chain Jiri Pirko
2017-03-24 17:46 ` Cong Wang [this message]
2017-03-24 17:55   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpVu=SCDZ7YdZDa3J9bugOsDb1Hzz=GnAS3r=-gAXik6gw@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).