From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [patch net-next 2/2] net/sched: fix filter flushing Date: Mon, 22 May 2017 14:04:58 -0700 Message-ID: References: <20170520130132.1626-1-jiri@resnulli.us> <20170520130132.1626-2-jiri@resnulli.us> <20170521055416.GA1848@nanopsycho> <20170521191941.GA4278@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Linux Kernel Network Developers , David Miller , Jamal Hadi Salim , Eric Dumazet , Daniel Borkmann , Simon Horman , mlxsw@mellanox.com, Colin King To: Jiri Pirko Return-path: Received: from mail-wm0-f53.google.com ([74.125.82.53]:32936 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933017AbdEVVFU (ORCPT ); Mon, 22 May 2017 17:05:20 -0400 Received: by mail-wm0-f53.google.com with SMTP id m7so10459917wmg.0 for ; Mon, 22 May 2017 14:05:19 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, May 22, 2017 at 1:54 PM, Cong Wang wrote: > On Sun, May 21, 2017 at 12:19 PM, Jiri Pirko wrote: >>>You can't claim you really delete it as long as actions can still >>>see it and dump it. >> >> No, user just wants to delete all the filters. That is done. User does >> not care if the actual chain structure is there or not. >> > > Hmm, so users see a chain with no filters... Fair enough. But since you remove the chain from the chain_list, it means users could not add new filters to this chain after flushing? And users could create a new chain with the same index?? If so, you should instead keep it in the chain_list, although empty.