From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B346DC43381 for ; Fri, 22 Mar 2019 17:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 854622190A for ; Fri, 22 Mar 2019 17:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yz51u5Be" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728960AbfCVRjt (ORCPT ); Fri, 22 Mar 2019 13:39:49 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42067 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfCVRjs (ORCPT ); Fri, 22 Mar 2019 13:39:48 -0400 Received: by mail-pf1-f195.google.com with SMTP id r15so1994755pfn.9 for ; Fri, 22 Mar 2019 10:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C7bvJrDB0QGenvFYms8BsVKHLvPpIpGAo3+T50PQSEE=; b=Yz51u5Be1IrxCGDSBvfXn6nTGhaE7bKRH7bNWOfzPhI1Isbm4O9lvtFDAzXXEtc8r8 U4Zuvvi3uJhqTT+8h4FVDQC9J8lNlWOzP7+EXbYla7WKPEP3QHKsNHYFE+kcJdl+9mr4 k+1y27lkVJ16Ox1r2AUaqCQN9e7M90EVrcdNW0SoK96djcrg63gCv5UKT9/GszLrS3gR K0iGqm3cvAyaV/6gXTUOzwUx6dKKAVsqQsfGL1sjYXkKNr4gA+BCsdAbzYGhFbMg/+hy uwVOtzA4DRtpU/gvW3VcRe0711HJhDHq6eHXtLjwTpvKO7gemh2IF3y7YqKu9DyvSk3H X8Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C7bvJrDB0QGenvFYms8BsVKHLvPpIpGAo3+T50PQSEE=; b=ExKHNavQgIYJpLLn1Ad+wa3TP2kZd5zUV4Tkb6Fvp+oUBV6wHbEB3GdwCjCtIADZ6N H+f0w1nNt7WZaFsVSnySG6uuIaxDDtEdD4SpqAikSq+OWZ1r9oHurXxhk3e2aA2oJnk+ 6dLrGt2/rZFAs2/DoPozUAtMSKsxNvMEaGI4hryjrg26ql9xJo0OXYr4dxnHC5kQQbcM KFlxKflLlHc3ShAf0OVAmgyM4xctkgVrjxl4ZsV9UU4Qt/CsTS3sLtPZKl2J4cHDpaND 4ErdqDRgQ7HNIk/3OC9vrsRTNF2shRwenUUo47DF9Hy6ZfOgHxKrmtLpaBDAoiDgbHNe umxA== X-Gm-Message-State: APjAAAWFvZoMhTa5lQtdtIc4XhnupOuk39BsJtY554IEo59suUS5j1Vy FcTbPHs3q/B5xne4/8Tk/IXfDFpp4/vRTWokuS6uxw== X-Google-Smtp-Source: APXvYqwZmD52F08RfJZhOqcaq0jPeUmJ+0NODBd6JSgUydepFaBGNnpmi1WkwweNAl5ahT8yTDvT5gMfegAaUENJqTE= X-Received: by 2002:a62:70c9:: with SMTP id l192mr10439861pfc.207.1553276388051; Fri, 22 Mar 2019 10:39:48 -0700 (PDT) MIME-Version: 1.0 References: <20190319194929.10798-1-ldir@darbyshire-bryant.me.uk> <20190322140905.64577-1-ldir@darbyshire-bryant.me.uk> In-Reply-To: <20190322140905.64577-1-ldir@darbyshire-bryant.me.uk> From: Cong Wang Date: Fri, 22 Mar 2019 10:39:36 -0700 Message-ID: Subject: Re: [RFC PATCH 1/1 v2] net: sched: Introduce conndscp action To: "Kevin 'ldir' Darbyshire-Bryant" Cc: "jhs@mojatatu.com" , "jiri@resnulli.us" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, On Fri, Mar 22, 2019 at 7:09 AM Kevin 'ldir' Darbyshire-Bryant wrote: > > Conndscp is a new tc filter action module. It is designed to copy DSCPs > to conntrack marks and the reverse operation of conntrack mark contained > DSCPs to the diffserv field of suitable skbs. > Is it possible and feasible to integrate this into connmark? Both are intended to retrieve information from conntrack and store it into skb. I know the name "connmark" already says it is a mark, while yours isn't, I still want to see if we can avoid code duplications. Thanks.