From: Cong Wang <xiyou.wangcong@gmail.com>
To: Linux Kernel Network Developers <netdev@vger.kernel.org>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Chris Mi <chrism@mellanox.com>, Jiri Pirko <jiri@mellanox.com>
Subject: Re: [Patch net] net_sched: remove cls_flower idr on failure
Date: Thu, 21 Sep 2017 11:50:32 -0700 [thread overview]
Message-ID: <CAM_iQpWAWLZ-wg3HBAxp35hZC=ysO65=2qPMCq-sw7PAdSkR3Q@mail.gmail.com> (raw)
In-Reply-To: <CAM_iQpX2QHqPFJ-vZz+6M4oDW2UgTbYdRuCxtNLm14S4sRVONg@mail.gmail.com>
On Thu, Sep 21, 2017 at 11:47 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Wed, Sep 20, 2017 at 9:18 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> +errout_idr:
>> + if (fnew->handle)
>> + idr_remove_ext(&head->handle_idr, fnew->handle);
>
> Hmm, I should check fold instead of fnew->handle here.
> I will update this patch.
Never mind, it should be the same logic. If fold is non-NULL,
then fnew->handle == 0.
It can be applied as it is.
next prev parent reply other threads:[~2017-09-21 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 16:18 [Patch net] net_sched: remove cls_flower idr on failure Cong Wang
2017-09-20 16:40 ` Jiri Pirko
2017-09-21 18:47 ` Cong Wang
2017-09-21 18:50 ` Cong Wang [this message]
2017-09-21 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpWAWLZ-wg3HBAxp35hZC=ysO65=2qPMCq-sw7PAdSkR3Q@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=chrism@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).