From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int() Date: Wed, 30 Oct 2013 15:01:12 -0700 Message-ID: References: <20131030.024003.1476890051483056287.davem@davemloft.net> <20131030.173200.2256841895208134119.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: TD Mackey , mchan@broadcom.com, Linux Kernel Network Developers , LKML To: David Miller Return-path: In-Reply-To: <20131030.173200.2256841895208134119.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Oct 30, 2013 at 2:32 PM, David Miller wrote: > > Explain to me then why other ethernet drivers implemented identically, > such as tg3, can use plain dev_kfree_skb() just fine? I don't think they are fine, I just don't see bug reports for them. At very least, I saw a same bug report for be2net too. To reproduce this bug, we need to find some one calling printk() within IRQ handler, which seems rare? It seems there are few people using hpsa driver together with netconsole.