From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39342C282D7 for ; Wed, 30 Jan 2019 16:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2F2C2087F for ; Wed, 30 Jan 2019 16:33:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WMWEH9hr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731956AbfA3Qdj (ORCPT ); Wed, 30 Jan 2019 11:33:39 -0500 Received: from mail-pf1-f179.google.com ([209.85.210.179]:41351 "EHLO mail-pf1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728720AbfA3Qdi (ORCPT ); Wed, 30 Jan 2019 11:33:38 -0500 Received: by mail-pf1-f179.google.com with SMTP id b7so47111pfi.8 for ; Wed, 30 Jan 2019 08:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wrpyaQIL9rz+2acSGrpqrjhYKsSZt5P1v566ORTfiTk=; b=WMWEH9hrQuOOUEJolnU1cfJY3pJUFYeUM62lQVuFk9ENGLSpX/te5BOLjPQHFYc12s KHW2sJ3Hae5p8UK2Ghqcb5MmIb5VhUaehwHpqTPKsutBWDmvHQRA3/v773hXYeOb4K7W mFqnnC2Bj156fNIJZG38VY4BbBwLUNZVoGqj1E8kemNJ/+1ja899hpnaHFZU3e8gQpQK VhwgL86EWyex+fW3CSAVvsGHQEdyeOI6/6fgmRcOJnjueZpeTjAW9ffUniNSEj5JNUnW j/OVYQr5GQ8i0RjbVEyZKw0wO6/gGgOlTF+a1HSSAZQjtU2r/EXuRNwC6F6Wi+8ARlLK 5qWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wrpyaQIL9rz+2acSGrpqrjhYKsSZt5P1v566ORTfiTk=; b=sO2vDK+2V74wdzFYXpSlZQ6l45jJGx+8VBlzb9u1S0+xbs9vKJ7xPCPmqt93cN2IVm OzSqpxsquu35nej9KoBUvyQRm+d/GhCoJxSV5pUoU2kjdCD1qL+PNsHslkuRfUP9y4Zn iro2rwVZvi/Kzx8nb6ULL1Ezg6TeozuaGGF0hT3IES7L6mS8m+49xQwdT4MaWwUI+EL2 bHD4lB4vpcpgFCbE4wjSrK9klbgTL4bVjJUnqF7EqgEv6dozU3MWCXoUZabnN6o6jBBI TSKVC2CkkoeeSut8LKTPZh/QtTVDAYKFAjMFj6Mv4SEzwzx5f6wASuYW5JGujLubeSYh 5rhg== X-Gm-Message-State: AJcUukex4W9uERdfdJLDysanyaaOenC7wVc/97qrBm8kTX4XATD3/XcN 5ehsdAa5vyhRqzGEy/1c6bVLrmcVACkmERNJekTkig== X-Google-Smtp-Source: ALg8bN7hxfzcdwYi0Lpr3zstJP3OcAPoBfreIr0a9kAossp6Hb0HI4HlHEzyI5BiU4+eXnZ0rvP3pBPgo+sufusd+FY= X-Received: by 2002:a63:d450:: with SMTP id i16mr27741255pgj.246.1548866017388; Wed, 30 Jan 2019 08:33:37 -0800 (PST) MIME-Version: 1.0 References: <20190130062737.15504-1-xiyou.wangcong@gmail.com> In-Reply-To: <20190130062737.15504-1-xiyou.wangcong@gmail.com> From: Cong Wang Date: Wed, 30 Jan 2019 08:33:25 -0800 Message-ID: Subject: Re: [Patch net] xfrm: destroy xfrm_state synchronously on net exit path To: Linux Kernel Network Developers Cc: syzbot , Steffen Klassert Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 29, 2019 at 10:27 PM Cong Wang wrote: > diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c > index f5b4febeaa25..08bf374a80eb 100644 > --- a/net/ipv6/xfrm6_tunnel.c > +++ b/net/ipv6/xfrm6_tunnel.c > @@ -344,8 +344,7 @@ static void __net_exit xfrm6_tunnel_net_exit(struct net *net) > struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net); > unsigned int i; > > - xfrm_state_flush(net, IPSEC_PROTO_ANY, false); > - xfrm_flush_gc(); > + xfrm_state_flush(net, IPSEC_PROTO_ANY, false, true); Well... We still have to wait for works scheduled from other call path. I will send v2.