From: Cong Wang <xiyou.wangcong@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv6: fix NULL dereference in ip6_route_dev_notify()
Date: Wed, 16 Aug 2017 13:16:39 -0700 [thread overview]
Message-ID: <CAM_iQpWEZMt=5o6_DWqsg-Qv82BhhwEfMY4t5LxYYXG9Ny+1LA@mail.gmail.com> (raw)
In-Reply-To: <1502912256.4936.150.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, Aug 16, 2017 at 12:37 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2017-08-16 at 12:15 -0700, Eric Dumazet wrote:
>> On Wed, 2017-08-16 at 11:50 -0700, Cong Wang wrote:
>> > On Tue, Aug 15, 2017 at 4:09 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> > > From: Eric Dumazet <edumazet@google.com>
>> > >
>> > > Based on a syzkaller report [1], I found that a per cpu allocation
>> > > failure in snmp6_alloc_dev() would then lead to NULL dereference in
>> > > ip6_route_dev_notify().
>> > >
>> > > It seems this is a very old bug, thus no Fixes tag in this submission.
>> >
>> >
>> > It should be introduced by my commit which introduces these
>> > in6_dev_put().
>> >
>>
>> Sorry, which commit exactly ?
>>
>> I got the issue on 4.3 up to latest 4.12
>
> Oh you're right, this was because I had backported
> 242d3a49a2a1a71d8eb9f953db1bcaa9d698ce00 into my trees a while back...
>
> So the bug was only added in 4.12
Yes this is correct.
prev parent reply other threads:[~2017-08-16 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 11:09 [PATCH net] ipv6: fix NULL dereference in ip6_route_dev_notify() Eric Dumazet
2017-08-16 0:06 ` David Miller
2017-08-16 18:50 ` Cong Wang
2017-08-16 19:15 ` Eric Dumazet
2017-08-16 19:37 ` Eric Dumazet
2017-08-16 20:16 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpWEZMt=5o6_DWqsg-Qv82BhhwEfMY4t5LxYYXG9Ny+1LA@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).