From: Cong Wang <xiyou.wangcong@gmail.com>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH net] ipv6: Fix cleanup ordering on inet6_init() error path
Date: Sat, 13 Jan 2018 09:39:23 -0800 [thread overview]
Message-ID: <CAM_iQpWO1iQTd6zWeWmxaOzHf==1dePsXjUZOSaKTcu4T6aH9g@mail.gmail.com> (raw)
In-Reply-To: <20180109182116.olzb5rroeazq4ufv@xylophone.i.decadent.org.uk>
On Tue, Jan 9, 2018 at 10:21 AM, Ben Hutchings
<ben.hutchings@codethink.co.uk> wrote:
> Commit 15e668070a64 reordered the initialisation in inet6_init() to
> fix a crash on an error path further down the call stack. It also
> reordered cleanup on the error path in inet6_init(), but the result
> is not the reverse of the initialisation order. This presumably
> can result in a resource leak or crash in some error cases. Reorder
> cleanup again to fix this.
>
> Fixes: 15e668070a64 ("ipv6: reorder icmpv6_init() and ip6_mr_init()")
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
prev parent reply other threads:[~2018-01-13 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 18:21 [PATCH net] ipv6: Fix cleanup ordering on inet6_init() error path Ben Hutchings
2018-01-10 22:25 ` Cong Wang
2018-01-11 16:48 ` Ben Hutchings
2018-01-13 17:38 ` Cong Wang
2018-01-13 17:39 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpWO1iQTd6zWeWmxaOzHf==1dePsXjUZOSaKTcu4T6aH9g@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=andreyknvl@google.com \
--cc=ben.hutchings@codethink.co.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).